[s3] Allow S3-compatible endpoints, expose more options#2759
[s3] Allow S3-compatible endpoints, expose more options#2759nanderson94 wants to merge 1 commit into
Conversation
|
❌ Author of the following commits did not sign a Contributor Agreement: Please, read and sign the above mentioned agreement if you want to contribute to this project |
navarone-feekery
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
Could you add some unit tests to cover the new configurations to the test file?
I think some good tests would be:
- ensuring
self.s3_endpoint_urlis assigned the right value in all circumstances - ensuring
self.configinitializes for all the options for new configss3_addressing_style,aws_use_fips_endpoint, andaws_use_dualstack_endpoint.
| "aws_use_dualstack_endpoint": { | ||
| "display": "toggle", | ||
| "label": "Use Dualstack Endpoints", | ||
| "order": 7, |
There was a problem hiding this comment.
Can you go through the order values for the configurations after this and update them?
|
This would be a great addition for us. We are running on-premise and can't use AWS, but do have Ceph OBS. Could someone have a look at the PR and include the missing items from the checklist? |
|
This feature could help us a lot as well, as we are also running an on-premise instance. |
Closes #2758
This change exposes many more configuration options of boto3 to the user. This has the primary intent of allowing S3-Compatible services to be used, but I also carried-through FIP and Dualstack endpoint selection.
Checklists
Pre-Review Checklist
config.yml.example)v7.13.2,v7.14.0,v8.0.0)Release Note
The S3 Connector now exposes options to support S3-Compatible object storage providers.