Search: Fix modal rejecting valid responses with content type "docs" (#3456)

* Fix search modal rejecting valid responses with type "docs"

The navigation-search contract changed the result item type value from
"doc" to "docs", but the frontend Zod schemas still enumerated ['doc',
'api'], causing SearchResponse.parse() to throw on every result item and
surface "Error loading search results" even for healthy 200 responses.

Also adds a console.error + logError branch for non-ApiError query
failures so ZodError/parse mismatches are no longer completely silent.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* Fix search schema: rename type → content_type with value 'docs'

---------

Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

Author: 3 people

src/Elastic.Documentation.Site/Assets/web-components/ModalSearch/ModalSearchResultsList.tsx

@@ -178,9 +178,9 @@ const ModalSearchResultRow = ({
             return result.parents.map((p) => p.title)
         }
 
-        const typePrefix = result.type === 'api' ? 'API' : 'Docs'
+        const typePrefix = 'Docs'
         return [typePrefix, ...result.parents.slice(1).map((p) => p.title)]
-    }, [result.type, result.parents])
+    }, [result.parents])
 
     return (
         <a

src/Elastic.Documentation.Site/Assets/web-components/ModalSearch/useModalSearchQuery.ts

@@ -1,5 +1,5 @@
 import { config } from '../../config'
-import { logInfo, logWarn } from '../../telemetry/logging'
+import { logError, logInfo, logWarn } from '../../telemetry/logging'
 import {
     ATTR_NAVIGATION_SEARCH_QUERY,
     ATTR_NAVIGATION_SEARCH_QUERY_LENGTH,
@@ -36,7 +36,7 @@ const SearchResultItemParent = z.object({
 })
 
 const SearchResultItem = z.object({
-    type: z.enum(['doc', 'api']),
+    content_type: z.enum(['docs']),
     url: z.string(),
     title: z.string(),
     description: z.string(),
@@ -189,6 +189,14 @@ export const useModalSearchQuery = () => {
                     'error.message': query.error.message,
                 })
             }
+        } else if (query.error) {
+            const err = query.error as Error
+            logError('modal_search_parse_error', {
+                [ATTR_NAVIGATION_SEARCH_QUERY]: debouncedSearchTerm,
+                [ATTR_ERROR_TYPE]: err.name,
+                'error.message': err.message,
+            })
+            console.error('[modal-search] failed to parse search response', err)
         }
     }, [query.error, debouncedSearchTerm])
 

src/Elastic.Documentation.Site/Assets/web-components/NavigationSearch/NavigationSearchTelemetry.test.tsx

@@ -32,15 +32,15 @@ const mockSearchResults = {
             title: 'Elasticsearch Guide',
             description: 'Learn about Elasticsearch',
             score: 0.95,
-            type: 'doc' as const,
+            content_type: 'docs' as const,
             parents: [{ title: 'Docs' }, { title: 'Elasticsearch' }],
         },
         {
             url: '/docs/kibana/dashboard',
             title: 'Kibana Dashboard',
             description: 'Create dashboards',
             score: 0.85,
-            type: 'doc' as const,
+            content_type: 'docs' as const,
             parents: [{ title: 'Docs' }, { title: 'Kibana' }],
         },
     ],

src/Elastic.Documentation.Site/Assets/web-components/NavigationSearch/SearchResultsList.tsx

@@ -158,9 +158,9 @@ const SearchResultRow = ({
             return result.parents.map((p) => p.title)
         }
 
-        const typePrefix = result.type === 'api' ? 'API' : 'Docs'
+        const typePrefix = 'Docs'
         return [typePrefix, ...result.parents.slice(1).map((p) => p.title)]
-    }, [result.type, result.parents])
+    }, [result.parents])
 
     return (
         <a

src/Elastic.Documentation.Site/Assets/web-components/NavigationSearch/useNavigationSearchQuery.ts

@@ -1,5 +1,5 @@
 import { config } from '../../config'
-import { logInfo, logWarn } from '../../telemetry/logging'
+import { logError, logInfo, logWarn } from '../../telemetry/logging'
 import {
     ATTR_NAVIGATION_SEARCH_QUERY,
     ATTR_NAVIGATION_SEARCH_QUERY_LENGTH,
@@ -40,7 +40,7 @@ const SearchResultItemParent = z.object({
 })
 
 const SearchResultItem = z.object({
-    type: z.enum(['doc', 'api']),
+    content_type: z.enum(['docs']),
     url: z.string(),
     title: z.string(),
     description: z.string(),
@@ -203,6 +203,17 @@ export const useNavigationSearchQuery = () => {
                     'error.message': query.error.message,
                 })
             }
+        } else if (query.error) {
+            const err = query.error as Error
+            logError('navigation_search_parse_error', {
+                [ATTR_NAVIGATION_SEARCH_QUERY]: debouncedSearchTerm,
+                [ATTR_ERROR_TYPE]: err.name,
+                'error.message': err.message,
+            })
+            console.error(
+                '[navigation-search] failed to parse search response',
+                err
+            )
         }
     }, [query.error, debouncedSearchTerm])