-
Notifications
You must be signed in to change notification settings - Fork 43
Render inline Markdown in automatic callouts and update docs #3324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ea16c97
Initial plan
Copilot d6db729
fix: render markdown in magic callouts
Copilot fe56163
test: align magic callout regression naming
Copilot 37592e9
fix: import markdig for magic callout rendering
Copilot 7d16dfb
test: fix magic callout link regression fixture
Copilot e198b84
Merge branch 'main' into copilot/fix-magic-callouts-formatting
leemthompo 4294eaa
docs: update code callouts section for clarity and inline formatting
leemthompo ad842b6
docs: don't make people read raw regex
leemthompo eec5e04
docs: expand callout examples and note link limitation
leemthompo ea6581d
docs: fold admonitions into intro prose per review
leemthompo be12a86
Merge branch 'main' into copilot/fix-magic-callouts-formatting
leemthompo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@theletterf apparently the
ShouldContainHtmlhelper inPrettyHtmlExtensions.cs:84has a bug: it assignsactualtoexpectedCompareinstead ofexpected, so the contains check isactual.Contains(actual)which always passes. This means any test usingShouldContainHtmlsilently passes regardless of output. TheMagicCallOutWithFormattingtest in this PR is affected: its input contains a/which the callout parser regex rejects, so no callout is generated, but the test still passes.out of scope for this PR presumably