Skip to content

Fix --version and __schema to report the semantic release version #3331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
theletterf wants to merge 2 commits into from
Closed

Fix --version and __schema to report the semantic release version #3331

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fdcc6a
Fix --version and __schema to report the semantic release version
theletterf May 18, 2026
6e3f3d3
Merge branch 'main' into fix-cli-version-output
theletterf May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 40 additions & 1 deletion src/tooling/docs-builder/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Elasticsearch B.V licenses this file to you under the Apache 2.0 License.
// See the LICENSE file in the project root for more information

using System.Reflection;
using Documentation.Builder;
using Documentation.Builder.Commands;
using Documentation.Builder.Commands.Assembler;
Expand All @@ -15,7 +16,39 @@
using Nullean.Argh;
using Nullean.Argh.Hosting;

// Pre-host fast path: run --help, --version, __schema, __completion directly and exit
var informationalVersion =
Assembly.GetExecutingAssembly().GetCustomAttribute<AssemblyInformationalVersionAttribute>()?.InformationalVersion
?? Assembly.GetExecutingAssembly().GetName().Version?.ToString()
?? "unknown";

// Intercept --version before Argh to print the semantic release version (set by
// MinVer) rather than the CLR assembly file version.
if (args is ["--version"])
{
Console.WriteLine(informationalVersion);
return;
}

// Intercept __schema to patch the version field in Argh's JSON output with the
// informational version. Argh calls Environment.Exit after writing; the ProcessExit
// handler below runs before the process terminates and rewrites the captured output.
if (args is ["__schema"])
{
var originalOut = Console.Out;
var captured = new StringWriter();
Console.SetOut(captured);

AppDomain.CurrentDomain.ProcessExit += (_, _) =>
{
var json = captured.ToString();
var patched = SchemaVersionRewriter.VersionField().Replace(json,
$@"$1""{informationalVersion}""");
originalOut.Write(patched);
originalOut.Flush();
};
}

// Pre-host fast path: run --help, __schema, __completion directly and exit
// before the host (and its startup logs) are ever constructed.
await ArghApp.TryArghIntrinsicCommand(args);

Expand Down Expand Up @@ -71,3 +104,9 @@

using var host = builder.Build();
await host.RunAsync();

internal static partial class SchemaVersionRewriter
{
[System.Text.RegularExpressions.GeneratedRegex(@"(""version""\s*:\s*)""[^""]*""")]
internal static partial System.Text.RegularExpressions.Regex VersionField();
}
Loading