Use singular S3 key prefixes for changelog/bundle artifacts#3434
Conversation
Align the S3 object key prefixes with the singular entity naming used
throughout the codebase (ArtifactType.Changelog / ArtifactType.Bundle).
Uploads now land under {product}/changelog/ and {product}/bundle/
instead of the plural {product}/changelogs/ and {product}/bundles/,
and the scrubber Lambda detects bundles via the /bundle/ path segment.
Co-authored-by: Cursor <cursoragent@cursor.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThis PR renames S3 object key paths for changelog and bundle uploads from plural to singular directory conventions. The 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Follows #3434, which moved bundle/changelog artifacts from {product}/bundles/ and {product}/changelogs/ to the singular {product}/bundle/ and {product}/changelog/. The CDN consumer fetched bundles from the old plural path, so it would 404 against the new layout; this points it at {product}/bundle/{file} and updates the registry docs/comments/tests to match. The directive's local-folder convention (changelog/bundles/) is unchanged. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Why
The changelog automation uploads artifacts to S3 under plural folder prefixes (
{product}/changelogs/and{product}/bundles/), but everywhere else in the codebase these entities are singular (ArtifactType.Changelog,ArtifactType.Bundle). This inconsistency is a small mishap worth correcting now, before any consumer reads the published layout from the CDN.What
Artifacts now upload under
{product}/changelog/and{product}/bundle/, and the scrubber Lambda detects bundles via the/bundle/path segment. Upload-target and incremental-uploader tests were updated to assert the new keys.This changes where new objects are written in the
elastic-docs-v3-changelog-bundles[-private]buckets. There is no consumer of these prefixes yet, so the only follow-up is housekeeping: optionally migrate/relabel any objects already written under the old plural prefixes (or let them age out). The S3 bucket names and the local:::{changelog}directive folder convention (changelog/bundles/in a docset) are unchanged.Companion docs-only PRs update the matching references in
docs-infraanddocs-actions.Made with Cursor