Changelog scrubber: keep links to public repos marked skip in assembler.yml#3653
Open
cotti wants to merge 2 commits into
Open
Changelog scrubber: keep links to public repos marked skip in assembler.yml#3653cotti wants to merge 2 commits into
cotti wants to merge 2 commits into
Conversation
…ler.yml The scrubber Lambda's allowlist excluded every reference repository marked skip: true, conflating "publishes no docs" with "is private". Public link-only repos such as elastic/roadmap (private: false, skip: true) had their PR/issue links stripped from bundles during the private-to-public bucket transition, even when explicitly listed in the bundle's link_allow_repos. Only private: true now excludes a repo from the allowlist. Closes elastic/docs-eng-team#661 Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Bundles from private repos lose links to public repos when the changelog scrubber Lambda copies them from the private to the public S3 bucket, even when those repos are explicitly listed in the bundle's
link_allow_repos. Concretely,elastic/cloud'scloud-2026-07-07.yamlbundle keepshttps://github.com/elastic/roadmap/issues/39at bundle time, but the public CDN copy has noissuesat all.Fixes elastic/docs-eng-team#661.
What
The Lambda builds its allowlist from the embedded
config/assembler.ymlviaLinkAllowlistSanitizer.BuildAllowReposFromAssembler, which excluded every reference repository markedskip: truein addition toprivate: true. Butskiponly means "don't clone/build docs from this repo" — it says nothing about visibility.elastic/roadmapwas added toassembler.ymlwithprivate: false, skip: true(#3053) precisely so changelog links to it would be recognized, and theskipflag defeated that.The allowlist now excludes only
private: truerepositories. Public skip-repos (elastic/roadmap,elastic/docs-builder) become linkable; allprivate: truerepos (which include every private team repo currently marked skip) remain scrubbed.Note for rollout: the Lambda redeploys via the release workflow (
changelog-scrubber-prodenvironment), and since scrubbing is S3-event-driven, already-published bundles stay scrubbed until their private-bucket objects are re-uploaded.