docs: default color mode follows the OS from 9.5 (#7132)#7278
Open
florent-leborgne wants to merge 3 commits into
Open
docs: default color mode follows the OS from 9.5 (#7132)#7278florent-leborgne wants to merge 3 commits into
florent-leborgne wants to merge 3 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Elastic Docs AI PR menuCheck the box to run an AI review for this pull request.
Powered by GitHub Agentic Workflows and docs-actions. For more information, reach out to the docs team. |
Contributor
🔍 Preview links for changed docs |
Contributor
✅ Elastic Docs Style Checker (Vale)No issues found on modified lines! The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
…de (#7132) Co-authored-by: Cursor <cursoragent@cursor.com>
…de setting (#7132) Co-authored-by: Cursor <cursoragent@cursor.com>
florent-leborgne
added a commit
to elastic/kibana
that referenced
this pull request
Jul 8, 2026
## Summary The `theme:darkMode` advanced setting reference (in `docs/reference/advanced-settings-space.yml`) doesn't document a default value. As of 9.5 the registered default changed from `disabled` to `system` (see #273826 / #242973), so a user with no saved color-mode preference now follows their OS color scheme. This PR adds the default to the setting description using the automated-settings per-version defaults idiom (inline `{applies_to}` badges in a bulleted list): * `stack: ga 9.5` — defaults to `system` * `stack: ga 9.0-9.4` — defaults to `disabled` (preserved cumulatively) The companion user-facing how-to update is in elastic/docs-content#7278. ### Verification Code: Default change verified against #273826 (`src/core/packages/ui-settings/server-internal/src/settings/theme.ts` → `getDefaultDarkModeValue` returns `'system'` for dist builds). Rendered docs: <img width="755" height="500" alt="image" src="https://github.com/user-attachments/assets/c81b79a9-2097-492d-8df5-832418041f84" /> --- > **AI-generated draft** — created with Claude Opus 4.8. Review for accuracy before merging. --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
yetanothertw
reviewed
Jul 8, 2026
| - **Space default**: Sets the color mode to the value defined in the [Space settings](kibana://reference/advanced-settings.md#kibana-general-settings) | ||
| - {applies_to}`serverless: unavailable` **Space default**: Sets the color mode to the value of the [`theme:darkMode`](kibana://reference/advanced-settings.md#theme-darkmode) advanced setting for the space. | ||
|
|
||
| :::{admonition} Deprecated |
Member
There was a problem hiding this comment.
Just wondering if the deprecation admonition here means there should also be deprecated badge in the applies_to for Space default?
yetanothertw
approved these changes
Jul 8, 2026
yetanothertw
left a comment
yetanothertw
left a comment
Member
There was a problem hiding this comment.
LGTM, thank you!
I've left a small comment for your consideration. I'm not sure whether or not the Space defaults item needs another applies_to for stack with a deprecated state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses #7132. Kibana 9.5 changes the registered default of the
theme:darkModesetting fromdisabled(light) tosystem, so a user with no saved color-mode preference now follows their OS color scheme, and System is pre-selected in the appearance selector. The dark-mode how-to still described light as the default, which is now inaccurate.cloud-account/dark-mode.md:stack: ga 9.5+serverless: gafollows the OS with System pre-selected;stack: ga 9.0-9.4preserves the prior light default). Removed the "default" wording from the Light option so the version-scoped bullet now carries it.serverless: unavailable, since that option is filtered out of the appearance selector in serverless, and linked it to the specifictheme:darkModeadvanced setting rather than a generic reference.Facts verified against the implementation PR elastic/kibana#273826 and source at HEAD (
theme.ts,appearance_modal.tsx,user_profile.tsx). Serverless filtering of Space default confirmed inappearance_modal.tsx(colorModeOptions.filter(({ id }) => id !== 'space_default')whenisServerless).Companion PR
The issue also flags the missing default on the Kibana advanced settings reference (
theme:darkMode). That reference is generated from a YAML file in theelastic/kibanarepo, so it's handled in a separate PR: elastic/kibana#277021 (documents thesystemdefault from 9.5,disabledbefore). The setting is already annotated as unavailable in serverless.Resolves
Closes #7132