assert on resource attributes

Author: SylvainJuge

smoke-tests/src/test/java/com/example/javaagent/smoketest/DeclarativeConfigSmokeTest.java

@@ -18,6 +18,17 @@
  */
 package com.example.javaagent.smoketest;
 
+import static io.opentelemetry.semconv.ServiceAttributes.SERVICE_INSTANCE_ID;
+import static io.opentelemetry.semconv.ServiceAttributes.SERVICE_NAME;
+import static io.opentelemetry.semconv.incubating.ContainerIncubatingAttributes.CONTAINER_ID;
+import static io.opentelemetry.semconv.incubating.HostIncubatingAttributes.HOST_ARCH;
+import static io.opentelemetry.semconv.incubating.HostIncubatingAttributes.HOST_NAME;
+import static io.opentelemetry.semconv.incubating.OsIncubatingAttributes.OS_TYPE;
+import static io.opentelemetry.semconv.incubating.OsIncubatingAttributes.OS_VERSION;
+import static io.opentelemetry.semconv.incubating.ProcessIncubatingAttributes.PROCESS_COMMAND_ARGS;
+import static io.opentelemetry.semconv.incubating.ProcessIncubatingAttributes.PROCESS_PID;
+import static io.opentelemetry.semconv.incubating.TelemetryIncubatingAttributes.TELEMETRY_DISTRO_NAME;
+import static io.opentelemetry.semconv.incubating.TelemetryIncubatingAttributes.TELEMETRY_DISTRO_VERSION;
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.tuple;
 
@@ -82,20 +93,41 @@ static void start() throws IOException {
             container
                 .withCopyFileToContainer(MountableFile.forHostPath(configFile), "/config.yaml")
                 .withEnv("OTEL_CONFIG_FILE", "/config.yaml")
-                .withEnv("OTEL_EXPORTER_OTLP_ENDPOINT", BACKEND_ENDPOINT),
+                .withEnv("OTEL_EXPORTER_OTLP_ENDPOINT", BACKEND_ENDPOINT)
+                .withEnv("OTEL_SERVICE_NAME", "my-service-name"),
         false);
   }
 
   @Test
-  void healthcheck() {
+  void resourceAttributes() {
     doRequest(getUrl("/health"), okResponseBody("Alive!"));
 
+    // This does not test that cloud resource providers are included in the config
+    // but at least we know that if they are added in the config their names are valid as otherwise
+    // the agent does not start with any missing component in config.
+
     List<ExportTraceServiceRequest> traces = waitForTraces();
     List<Span> spans = getSpans(traces).toList();
     assertThat(spans)
         .hasSize(1)
         .extracting("name", "kind")
         .containsOnly(tuple("GET /health", Span.SpanKind.SPAN_KIND_SERVER));
+
+    assertThat(getResourceAttributes(traces))
+        .containsKey(HOST_NAME.getKey())
+        .containsKey(HOST_ARCH.getKey())
+        .containsKey(OS_TYPE.getKey())
+        .containsKey(OS_VERSION.getKey())
+        .containsKey(PROCESS_PID.getKey())
+        .containsKey(PROCESS_COMMAND_ARGS.getKey())
+        .containsKey(CONTAINER_ID.getKey())
+        // service name should be provided by the 'service' resource attribute detector which
+        // reads environment variables (here it's not env variable injected in declarative config).
+        .containsEntry(SERVICE_NAME.getKey(), attributeValue("my-service-name"))
+        .containsKey(SERVICE_INSTANCE_ID.getKey())
+        // ensures that we override the default distro resource attributes
+        .containsEntry(TELEMETRY_DISTRO_NAME.getKey(), attributeValue("elastic"))
+        .containsKey(TELEMETRY_DISTRO_VERSION.getKey());
   }
 
   @AfterAll

smoke-tests/src/test/java/com/example/javaagent/smoketest/SmokeTest.java

@@ -384,6 +384,13 @@ protected Stream<Span> getSpans(List<ExportTraceServiceRequest> traces) {
         .flatMap(it -> it.getSpansList().stream());
   }
 
+  protected Map<String, AnyValue> getResourceAttributes(List<ExportTraceServiceRequest> traces) {
+    return traces.stream()
+        .flatMap(it -> it.getResourceSpansList().stream())
+        .flatMap(it -> it.getResource().getAttributesList().stream())
+        .collect(Collectors.toMap(KeyValue::getKey, KeyValue::getValue));
+  }
+
   protected static String bytesToHex(byte[] bytes) {
     StringBuilder sb = new StringBuilder();
     for (int i = 0; i < bytes.length; i++) {