declarative config metrics delta#1062
Conversation
📋 Changelog🔖 Add one of these type labels to your PR:
🔖 To skip changelog generation or configure label rules, see |
| @@ -60,15 +60,17 @@ static void afterAll() { | |||
| @Test | |||
| void tomcat() { | |||
| target = | |||
There was a problem hiding this comment.
[for reviewer] this (and below) a test refactor to use builder pattern to make test slightly more readable/maintainable.
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 41 minutes and 42 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughConfiguration updates set 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@custom/src/main/resources/co/elastic/otel/config.yaml`:
- Around line 47-55: The temporality_preference under the otlp_http exporter is
hard-coded to "delta"; change it to read from the
OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE environment variable with a
default of "delta" (same ${VAR:-default} pattern used for endpoint and
headers_list) so users can override temporality to "cumulative" or "lowmemory";
update the temporality_preference setting in the otlp_http block accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: ec6c6c21-6e1b-4559-b4bd-95cdd968c1c0
📒 Files selected for processing (5)
custom/src/main/resources/co/elastic/otel/config.yamlcustom/src/test/java/co/elastic/otel/declarativeconfig/DefaultDeclarativeConfigTest.javasmoke-tests/src/test/java/com/example/javaagent/smoketest/AppServerProvidersTest.javasmoke-tests/src/test/java/com/example/javaagent/smoketest/SmokeTest.javasmoke-tests/src/test/java/com/example/javaagent/smoketest/TestAppSmokeTest.java
part of #1054
replaces #1058