Migrate sampler to non-contrib SDK incubator implementation

[anuraaga]

No description provided.

[github-actions]

📋 Changelog

Generated changelog entry for docs/changelog/1091\.yaml:

prs:
- "1091"
type: enhancement
products:
- product: edot-java
  lifecycle: ga
title: Migrate sampler to non-contrib SDK incubator implementation

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes replace the consistent sampling library with the composite sampler framework. The libs.contribConsistentSampling dependency and its transitive exclusions are removed from the build configuration. The sampler implementation is updated to use composite sampler construction via parentThreshold() combined with probability(ratio) instead of ConsistentSampler. Imports are updated accordingly to reflect the new sampler types.

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

• 🛠️ Update Documentation: Commit on current branch
• 🛠️ Update Documentation: Create PR

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Review rate limit: 0/1 reviews remaining, refill in 60 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

custom/src/main/java/co/elastic/otel/compositesampling/DynamicCompositeParentBasedTraceIdRatioBasedSampler.java (1)

54-57: ⚠️ Potential issue | 🔴 Critical | ⚡ Quick win

Fix the recursive description implementation.

getDescription() calls INSTANCE.getDescription(), which recurses on the same singleton and will overflow the stack as soon as the SDK asks for a description.

Suggested fix

 `@Override`
 public String getDescription() {
-  return INSTANCE.getDescription();
+  return delegate.getDescription();
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@custom/src/main/java/co/elastic/otel/compositesampling/DynamicCompositeParentBasedTraceIdRatioBasedSampler.java`
around lines 54 - 57, The getDescription method currently calls
INSTANCE.getDescription(), causing infinite recursion; change it to return the
description of the underlying/wrapped sampler used by this composite (not the
singleton INSTANCE). In other words, inside
DynamicCompositeParentBasedTraceIdRatioBasedSampler.getDescription() return the
wrapped sampler's description (e.g., wrappedSampler.getDescription() or
delegateSampler.getDescription() — whatever field holds the underlying sampler
in this class) or a fixed descriptive string for this composite, instead of
delegating to INSTANCE.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In
`@custom/src/main/java/co/elastic/otel/compositesampling/DynamicCompositeParentBasedTraceIdRatioBasedSampler.java`:
- Around line 54-57: The getDescription method currently calls
INSTANCE.getDescription(), causing infinite recursion; change it to return the
description of the underlying/wrapped sampler used by this composite (not the
singleton INSTANCE). In other words, inside
DynamicCompositeParentBasedTraceIdRatioBasedSampler.getDescription() return the
wrapped sampler's description (e.g., wrappedSampler.getDescription() or
delegateSampler.getDescription() — whatever field holds the underlying sampler
in this class) or a fixed descriptive string for this composite, instead of
delegating to INSTANCE.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 081d07c9-6e2a-4820-8ae1-3c72eb894023

📥 Commits

Reviewing files that changed from the base of the PR and between 9e8e95b and 5766185.

📒 Files selected for processing (2)

• custom/build.gradle.kts
• custom/src/main/java/co/elastic/otel/compositesampling/DynamicCompositeParentBasedTraceIdRatioBasedSampler.java

💤 Files with no reviewable changes (1)

• custom/build.gradle.kts

[jackshirazi]

there's no need for this. we'll migrate the entire dynamic control to the contributed implementation when that's available, then this sampler gets removed, so there's no point in doing this in the interim

[anuraaga]

@jackshirazi - Just to confirm what do you mean by that? This is the implementation I wrote based on the spec vs contrib which was a pre-spec POC. Isn't it good to switch to the maintained implementation?

I mean I can send a PR to remove the contrib implementation which I think would be merged - would it help? 😉

[jackshirazi]

This agent will move to use the dynamic control extension currently being added to contrib. That dynamic control extension already uses the SDK incubator sampler. So applying this PR would soon be pointless, so we'll avoid that additional work for now. Thanks for the contribution though, it would be right if we weren't aiming to switch relatively soon