Skip to content

service.namespace is stable #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SylvainJuge merged 1 commit into from
May 6, 2026
Merged

service.namespace is stable #1096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...ersal-profiling-integration/src/main/java/co/elastic/otel/ProfilerSharedMemoryWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,7 @@ static ByteBuffer generateProcessCorrelationStorage(
if (serviceName == null) {
throw new IllegalStateException("A service name must be configured!");
}
String environment =
serviceResource.getAttribute(UniversalProfilingIncubatingAttributes.SERVICE_NAMESPACE);
String environment = serviceResource.getAttribute(ServiceAttributes.SERVICE_NAMESPACE);

ByteBuffer buffer = ByteBuffer.allocateDirect(4096);
buffer.order(ByteOrder.nativeOrder());
Expand Down
2 changes: 0 additions & 2 deletions ...ing-integration/src/main/java/co/elastic/otel/UniversalProfilingIncubatingAttributes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,5 @@ private UniversalProfilingIncubatingAttributes() {}

// not yet part of stable semantic conventions, inlined here to prevent dependency issues

public static final AttributeKey<String> SERVICE_NAMESPACE =
AttributeKey.stringKey("service.namespace");
public static final AttributeKey<String> HOST_ID = AttributeKey.stringKey("host.id");
}
8 changes: 0 additions & 8 deletions ...integration/src/test/java/co/elastic/otel/UniversalProfilingIncubatingAttributesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,18 +22,10 @@

import io.opentelemetry.api.common.AttributeKey;
import io.opentelemetry.semconv.incubating.HostIncubatingAttributes;
import io.opentelemetry.semconv.incubating.ServiceIncubatingAttributes;
import org.junit.jupiter.api.Test;

public class UniversalProfilingIncubatingAttributesTest {

@Test
void serviceNamespace() {
check(
UniversalProfilingIncubatingAttributes.SERVICE_NAMESPACE,
ServiceIncubatingAttributes.SERVICE_NAMESPACE);
}

@Test
void hostId() {
check(UniversalProfilingIncubatingAttributes.HOST_ID, HostIncubatingAttributes.HOST_ID);
Expand Down
3 changes: 1 addition & 2 deletions ...-profiling-integration/src/test/java/co/elastic/otel/UniversalProfilingProcessorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@
import io.opentelemetry.sdk.trace.samplers.SamplingResult;
import io.opentelemetry.semconv.ServiceAttributes;
import io.opentelemetry.semconv.incubating.HostIncubatingAttributes;
import io.opentelemetry.semconv.incubating.ServiceIncubatingAttributes;
import java.lang.ref.WeakReference;
import java.nio.ByteBuffer;
import java.nio.ByteOrder;
Expand Down Expand Up @@ -254,7 +253,7 @@ public void testProcessStoragePopulated() {
Resource withNamespace =
Resource.builder()
.put(ServiceAttributes.SERVICE_NAME, "service Ä 1")
.put(ServiceIncubatingAttributes.SERVICE_NAMESPACE, "my nameßspace")
.put(ServiceAttributes.SERVICE_NAMESPACE, "my nameßspace")
.build();
try (OpenTelemetrySdk sdk = initSdk(withNamespace, b -> {}, Sampler.alwaysOn())) {
checkProcessStorage("service Ä 1", "my nameßspace");
Expand Down
Loading