From ce4ba0a9265bc228afd3cd03222399731a9e2bdb Mon Sep 17 00:00:00 2001
From: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
Date: Fri, 16 Jan 2026 18:48:50 +0100
Subject: [PATCH] Better builder for Time (#1141)

* better builder for time

* checkstyle
---
 .../clients/elasticsearch/_types/Time.java    |  5 ++++
 .../elasticsearch/model/OverloadsTest.java    | 25 +++++++++++++++++--
 2 files changed, 28 insertions(+), 2 deletions(-)

diff --git a/java-client/src/main/java/co/elastic/clients/elasticsearch/_types/Time.java b/java-client/src/main/java/co/elastic/clients/elasticsearch/_types/Time.java
index e4bcef5000..1fdbbc45ed 100644
--- a/java-client/src/main/java/co/elastic/clients/elasticsearch/_types/Time.java
+++ b/java-client/src/main/java/co/elastic/clients/elasticsearch/_types/Time.java
@@ -194,6 +194,11 @@ public Time build() {
 			return new Time(this);
 		}
 
+		public ObjectBuilder<Time> time(Integer t, TimeUnit u) {
+			this._kind = Kind.Time;
+			this._value = String.valueOf(t).concat(u.jsonValue());
+			return this;
+		}
 	}
 
 	private static JsonpDeserializer<Time> buildTimeDeserializer() {
diff --git a/java-client/src/test/java/co/elastic/clients/elasticsearch/model/OverloadsTest.java b/java-client/src/test/java/co/elastic/clients/elasticsearch/model/OverloadsTest.java
index a97e111329..5357e92444 100644
--- a/java-client/src/test/java/co/elastic/clients/elasticsearch/model/OverloadsTest.java
+++ b/java-client/src/test/java/co/elastic/clients/elasticsearch/model/OverloadsTest.java
@@ -23,9 +23,12 @@
 import co.elastic.clients.elasticsearch._types.FieldSort;
 import co.elastic.clients.elasticsearch._types.FieldValue;
 import co.elastic.clients.elasticsearch._types.ScriptSource;
+import co.elastic.clients.elasticsearch._types.Time;
+import co.elastic.clients.elasticsearch._types.TimeUnit;
 import co.elastic.clients.elasticsearch._types.aggregations.TopMetrics;
 import co.elastic.clients.elasticsearch._types.query_dsl.MatchAllQuery;
 import co.elastic.clients.elasticsearch.core.MsearchRequest;
+import co.elastic.clients.elasticsearch.core.OpenPointInTimeRequest;
 import co.elastic.clients.elasticsearch.core.SearchRequest;
 import co.elastic.clients.elasticsearch.core.SearchResponse;
 import co.elastic.clients.testkit.ModelTestCase;
@@ -89,12 +92,12 @@ public void voidClassTDocumentOverload() throws IOException {
         // nor testing anything, just checking that this compiles
         ElasticsearchClient client = ElasticsearchClient.of(e -> e.host("http://localhost:9200"));
 
-        SearchResponse<Void> resp = client.search(s -> s,Void.class);
+        SearchResponse<Void> resp = client.search(s -> s, Void.class);
         SearchResponse<Void> respDefault = client.search(s -> s);
     }
 
     @Test
-    public void searchRequestBodyOverloads() throws IOException {
+    public void searchRequestBodyOverloads() {
 
         // Normal search request
         SearchRequest searchRequest = SearchRequest.of(b -> b
@@ -147,4 +150,22 @@ public void searchRequestBodyOverloads() throws IOException {
         // Assert both variants result in the same serialization
         assertEquals(scriptSourceStandard.toString(), scriptSourceOverload.toString());
     }
+
+    @Test
+    public void timeOverload() {
+        OpenPointInTimeRequest opr = OpenPointInTimeRequest.of(o -> o.index("test").keepAlive(k -> k.time(
+            "5s")));
+        OpenPointInTimeRequest opr1 =
+            OpenPointInTimeRequest.of(o -> o.index("test").keepAlive(k -> k.time(5, TimeUnit.Seconds)));
+        OpenPointInTimeRequest opr2 =
+            OpenPointInTimeRequest.of(o -> o.index("test").keepAlive(Time.of(t -> t.time("5s"))));
+        OpenPointInTimeRequest opr3 =
+            OpenPointInTimeRequest.of(o -> o.index("test").keepAlive(Time.of(t -> t.time(5,
+                TimeUnit.Seconds))));
+
+        // Assert all variants result in the same serialization
+        assertEquals(opr.toString(), opr1.toString());
+        assertEquals(opr.toString(), opr2.toString());
+        assertEquals(opr.toString(), opr3.toString());
+    }
 }