Adopt latest patch release for http client#1227
Merged
Merged
Conversation
This commit updates the `org.apache.httpcomponents.client5` dep to get the latest bug fixes. Release notes: https://github.com/apache/httpcomponents-client/blob/rel/v5.6.1/RELEASE_NOTES.txt
Member
Author
|
Not sure what the corresponding release notes or docs would be required for this. Let me know and I can work on those. Thanks :) |
l-trotta
approved these changes
May 4, 2026
Contributor
|
@donoghuc thanks! no need for docs :) |
This was referenced May 4, 2026
l-trotta
added a commit
that referenced
this pull request
May 4, 2026
This commit updates the `org.apache.httpcomponents.client5` dep to get the latest bug fixes. Release notes: https://github.com/apache/httpcomponents-client/blob/rel/v5.6.1/RELEASE_NOTES.txt Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
l-trotta
added a commit
that referenced
this pull request
May 4, 2026
This commit updates the `org.apache.httpcomponents.client5` dep to get the latest bug fixes. Release notes: https://github.com/apache/httpcomponents-client/blob/rel/v5.6.1/RELEASE_NOTES.txt Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
This was referenced May 5, 2026
donoghuc
added a commit
to donoghuc/logstash-filter-elastic_integration
that referenced
this pull request
May 7, 2026
The shadow jar task merges two dependency sources: a `fileTree` copy of jars from the ES source build (`elasticsearchMinimalCore`) and Maven-resolved dependencies from `elasticsearch-java` (`elasticsearchClient`). Because `elasticsearchMinimalCore` is listed first, its `httpclient5-5.5.jar` from x-pack-core takes precedence over the patched `httpclient5-5.6.1.jar` resolved via Maven from `elasticsearch-java 9.4.0`. Exclude httpclient5, httpcore5, and httpcore5-h2 from the x-pack-core module copy so the Maven-resolved versions are the sole source. This ensures the plugin ships the patched `httpclient5` `5.6.1` regardless of what version the ES server source build bundles. Related: - elastic/elasticsearch-java#1227 - elastic/elasticsearch#148345
donoghuc
added a commit
to donoghuc/logstash-filter-elastic_integration
that referenced
this pull request
May 11, 2026
The shadow jar task merges two dependency sources: a `fileTree` copy of jars from the ES source build (`elasticsearchMinimalCore`) and Maven-resolved dependencies from `elasticsearch-java` (`elasticsearchClient`). Because `elasticsearchMinimalCore` is listed first, its `httpclient5-5.5.jar` from x-pack-core takes precedence over the patched `httpclient5-5.6.1.jar` resolved via Maven from `elasticsearch-java 9.4.0`. Exclude httpclient5, httpcore5, and httpcore5-h2 from the x-pack-core module copy so the Maven-resolved versions are the sole source. This ensures the plugin ships the patched `httpclient5` `5.6.1` regardless of what version the ES server source build bundles. Related: - elastic/elasticsearch-java#1227 - elastic/elasticsearch#148345
donoghuc
added a commit
to elastic/logstash-filter-elastic_integration
that referenced
this pull request
May 11, 2026
* Ship ONLY httpclient5 5.6.1 The shadow jar task merges two dependency sources: a `fileTree` copy of jars from the ES source build (`elasticsearchMinimalCore`) and Maven-resolved dependencies from `elasticsearch-java` (`elasticsearchClient`). Because `elasticsearchMinimalCore` is listed first, its `httpclient5-5.5.jar` from x-pack-core takes precedence over the patched `httpclient5-5.6.1.jar` resolved via Maven from `elasticsearch-java 9.4.0`. Exclude httpclient5, httpcore5, and httpcore5-h2 from the x-pack-core module copy so the Maven-resolved versions are the sole source. This ensures the plugin ships the patched `httpclient5` `5.6.1` regardless of what version the ES server source build bundles. Related: - elastic/elasticsearch-java#1227 - elastic/elasticsearch#148345 * add changelog entry
donoghuc
added a commit
to elastic/logstash-filter-elastic_integration
that referenced
this pull request
May 11, 2026
* Ship ONLY httpclient5 5.6.1 (#455) * Ship ONLY httpclient5 5.6.1 The shadow jar task merges two dependency sources: a `fileTree` copy of jars from the ES source build (`elasticsearchMinimalCore`) and Maven-resolved dependencies from `elasticsearch-java` (`elasticsearchClient`). Because `elasticsearchMinimalCore` is listed first, its `httpclient5-5.5.jar` from x-pack-core takes precedence over the patched `httpclient5-5.6.1.jar` resolved via Maven from `elasticsearch-java 9.4.0`. Exclude httpclient5, httpcore5, and httpcore5-h2 from the x-pack-core module copy so the Maven-resolved versions are the sole source. This ensures the plugin ships the patched `httpclient5` `5.6.1` regardless of what version the ES server source build bundles. Related: - elastic/elasticsearch-java#1227 - elastic/elasticsearch#148345 * add changelog entry (cherry picked from commit aac830c) # Conflicts: # CHANGELOG.md * release prep --------- Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
donoghuc
added a commit
to elastic/logstash-filter-elastic_integration
that referenced
this pull request
May 11, 2026
* Ship ONLY httpclient5 5.6.1 (#455) * Ship ONLY httpclient5 5.6.1 The shadow jar task merges two dependency sources: a `fileTree` copy of jars from the ES source build (`elasticsearchMinimalCore`) and Maven-resolved dependencies from `elasticsearch-java` (`elasticsearchClient`). Because `elasticsearchMinimalCore` is listed first, its `httpclient5-5.5.jar` from x-pack-core takes precedence over the patched `httpclient5-5.6.1.jar` resolved via Maven from `elasticsearch-java 9.4.0`. Exclude httpclient5, httpcore5, and httpcore5-h2 from the x-pack-core module copy so the Maven-resolved versions are the sole source. This ensures the plugin ships the patched `httpclient5` `5.6.1` regardless of what version the ES server source build bundles. Related: - elastic/elasticsearch-java#1227 - elastic/elasticsearch#148345 * add changelog entry (cherry picked from commit aac830c) * release prep --------- Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the
org.apache.httpcomponents.client5dep to get the latest bug fixes.Release notes: https://github.com/apache/httpcomponents-client/blob/rel/v5.6.1/RELEASE_NOTES.txt