Skip to content

ti_domaintools: update domaintools API authentication method#20144

Open
cpanares wants to merge 7 commits into
elastic:mainfrom
DomainTools:ti_domaintools
Open

ti_domaintools: update domaintools API authentication method#20144
cpanares wants to merge 7 commits into
elastic:mainfrom
DomainTools:ti_domaintools

Conversation

@cpanares

@cpanares cpanares commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown
  • Enhancement

Proposed commit message

Use header-based authentication for DomainTools API.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

  • Clone integrations repo.
  • Install the elastic package locally.
  • Start the elastic stack using the elastic package.
  • Configure the settings and wait for the feeds to start working.
  • Enable request tracing for the selected feed. All feeds will have the enhancement.
  • Go to the Filebeat logs directory to check the requests.

Related issues

N/A

Screenshots

N/A

@cla-checker-service

cla-checker-service Bot commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown

💚 CLA has been signed

@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Reviewers

Buildkite won't run for external contributors automatically; you need to add a comment:

  • /test : will kick off a build in Buildkite.

NOTE: https://github.com/elastic/integrations/blob/main/.buildkite/pull-requests.json contains all those details.

@cpanares
cpanares marked this pull request as ready for review July 15, 2026 19:04
@cpanares
cpanares requested review from a team as code owners July 15, 2026 19:04
efd6
efd6 reviewed Jul 15, 2026
View reviewed changes

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the proposed commit message to explain why this is an enhancement? Does the current implementation still work? If not, this is a bug-fix. Please format the proposed commit message as plain prose rather than the WHAT/WHY format it currently is in.

Comment thread packages/ti_domaintools/changelog.yml Outdated
@andrewkroh andrewkroh added Integration:ti_domaintools DomainTools Feeds (Partner supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Jul 16, 2026
@infra-vault-gh-plugin-prod

infra-vault-gh-plugin-prod Bot commented Jul 16, 2026

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

efd6
efd6 reviewed Jul 16, 2026
View reviewed changes

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the proposed commit message.

Comment thread packages/ti_domaintools/changelog.yml Outdated
@efd6

efd6 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

/test

@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@vera-review-bot

vera-review-bot Bot commented Jul 17, 2026

Copy link
Copy Markdown

⚠️ @cpanares I couldn't complete the review for commits 1067710 after several attempts. A maintainer can re-run it with @vera-review-bot review.

@efd6

efd6 commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

/test

@efd6

efd6 commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Please update the proposed commit message here.

@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

✅ All changelog entries have the correct PR link.

@infra-vault-gh-plugin-prod

infra-vault-gh-plugin-prod Bot commented Jul 19, 2026

Copy link
Copy Markdown

💚 Build Succeeded

History

@cpanares

cpanares commented Jul 20, 2026

Copy link
Copy Markdown
Author

@efd6 done updating the commit message in the comment. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efd6 efd6 efd6 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Integration:ti_domaintools DomainTools Feeds (Partner supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cpanares @efd6 @andrewkroh