Skip to content

[Netbox] Set default for disable_keep_alive to false#18679

Closed
tehbooom wants to merge 3 commits into
elastic:mainfrom
tehbooom:netbox_18665
Closed

[Netbox] Set default for disable_keep_alive to false#18679
tehbooom wants to merge 3 commits into
elastic:mainfrom
tehbooom:netbox_18665

Conversation

@tehbooom

@tehbooom tehbooom commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

Proposed commit message

Set default for disable_keep_alive to false

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@tehbooom tehbooom requested a review from a team as a code owner April 28, 2026 18:56
@tehbooom tehbooom added bugfix Pull request that fixes a bug issue Integration:netbox NetBox labels Apr 28, 2026
Comment thread packages/netbox/changelog.yml
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@andrewkroh andrewkroh added the Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] label Apr 28, 2026
@mrodm

mrodm commented May 4, 2026

Copy link
Copy Markdown
Collaborator

@mrodm

mrodm commented May 8, 2026

Copy link
Copy Markdown
Collaborator

Hi @elastic/obs-infraobs-integrations !
Could you take a look to this PR ? Latest daily builds testing this package are failing and this looks it could solve those flaky-tests.

Thanks!!

@Niceplace Niceplace left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great approach ! LGTM

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

@mrodm

mrodm commented May 21, 2026

Copy link
Copy Markdown
Collaborator

Hi @elastic/obs-infraobs-integrations !
Could you take a look to this PR ? This would solve some flaky-tests that are also happening in pull requests targeting main branch.

Thanks!!

@mrodm

mrodm commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Hi !
@elastic/obs-infraobs-integrations could you take a look to this PR ?

This would solve some flaky-tests from daily builds that are also happening in pull requests targeting main branch.

Thanks!!

@mrodm

mrodm commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Relates to #19889

@andrewkroh

Copy link
Copy Markdown
Member

Thanks. This is now fixed in main. I didn't see it until after I had a fix ready.

@andrewkroh andrewkroh closed this Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment