[hackerone] Initial release of HackerOne with Report data streams#18951
[hackerone] Initial release of HackerOne with Report data streams#18951clement-fouque wants to merge 34 commits into
Conversation
Vale Linting ResultsSummary: 9 warnings, 35 suggestions found
|
| File | Line | Rule | Message |
|---|---|---|---|
| packages/hackerone/docs/README.md | 116 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/hackerone/docs/README.md | 116 | Elastic.DontUse | Don't use 'please'. |
| packages/hackerone/docs/README.md | 359 | Elastic.DontUse | Don't use 'just'. |
| packages/hackerone/docs/README.md | 375 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/hackerone/docs/README.md | 375 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/hackerone/docs/README.md | 488 | Elastic.DontUse | Don't use 'Thus'. |
| packages/hackerone/docs/README.md | 510 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/hackerone/docs/README.md | 510 | Elastic.DontUse | Don't use 'please'. |
| packages/hackerone/docs/README.md | 754 | Elastic.DontUse | Don't use 'just'. |
💡 Suggestions (35)
| File | Line | Rule | Message |
|---|---|---|---|
| packages/hackerone/_dev/build/docs/README.md | 87 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
| packages/hackerone/_dev/build/docs/README.md | 93 | Elastic.Semicolons | Use semicolons judiciously. |
| packages/hackerone/docs/README.md | 88 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 94 | Elastic.Semicolons | Use semicolons judiciously. |
| packages/hackerone/docs/README.md | 106 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 114 | Elastic.Wordiness | Consider using 'tell' instead of 'inform'. |
| packages/hackerone/docs/README.md | 114 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 114 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 116 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 116 | Elastic.WordChoice | Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 117 | Elastic.WordChoice | Consider using 'efficiently' instead of 'simply', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 117 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 124 | Elastic.Clone | Use cloning only when referring to cloning a GitHub repository or creating a copy that is linked to the original. Often confused with 'copy' and 'duplicate'. |
| packages/hackerone/docs/README.md | 227 | Elastic.WordChoice | Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 242 | Elastic.WordChoice | Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 259 | Elastic.WordChoice | Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 326 | Elastic.WordChoice | Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 336 | Elastic.WordChoice | Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 359 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 500 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 508 | Elastic.Wordiness | Consider using 'tell' instead of 'inform'. |
| packages/hackerone/docs/README.md | 508 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 508 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 510 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 510 | Elastic.WordChoice | Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 511 | Elastic.WordChoice | Consider using 'efficiently' instead of 'simply', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 511 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 518 | Elastic.Clone | Use cloning only when referring to cloning a GitHub repository or creating a copy that is linked to the original. Often confused with 'copy' and 'duplicate'. |
| packages/hackerone/docs/README.md | 621 | Elastic.WordChoice | Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 636 | Elastic.WordChoice | Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 653 | Elastic.WordChoice | Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 720 | Elastic.WordChoice | Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 730 | Elastic.WordChoice | Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 754 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
| packages/hackerone/docs/README.md | 793 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
The Vale linter checks documentation changes against the Elastic Docs style guide.
To use Vale locally or report issues, refer to Elastic style guide for Vale.
|
@efd6 can you perform a review of the CEL part? Thanks. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🚀 Benchmarks reportTo see the full report comment with |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
7ab7673 to
92037e3
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
d394b3e to
ce28db2
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…ment-fouque/elastic-integrations into hackerone-new-integration-v5
…s for JSON acceptance
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
TL;DR
Remediation
Investigation detailsRoot CauseThe root cause is not identifiable from the available log artifact. The only captured lines are stack teardown and artifact upload, followed by a generic non-zero exit. Evidence
Verification
Follow-upShare the failing Note 🔒 Integrity filter blocked 2 itemsThe following items were blocked because they don't meet the GitHub integrity level.
To allow these resources, lower tools:
github:
min-integrity: approved # merged | approved | unapproved | noneWhat is this? | From workflow: PR Buildkite Detective Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
| description: |- | ||
| Program handles to restrict results (`filter[program][]`). | ||
| Provide at least one program handle **or** one inbox id — the API requires one scope filter. | ||
| multi: true | ||
| required: false | ||
| show_user: true | ||
| - name: inbox_ids | ||
| type: text | ||
| title: Inbox IDs | ||
| description: |- | ||
| Inbox identifiers (`filter[inbox_ids][]`). At least one program handle **or** one inbox id is required by the API. |
There was a problem hiding this comment.
How does this work? I don't really understand the format the user has to provide this in. You could possibly have a default value but have it commented out?
If these are an array of just values, its better that we just ask them to give us a list of values as for example type text and multi true, then build the array in the configuration itself?
…product, and vulnerability.scanner.vendor in ecs.yml
…clarity and consistency. Updated mappings for event ID, vulnerability details, user information, and organization attributes to use 'rename' instead of 'set' for better alignment with ECS standards.
…ation to clarify usage and accepted units.
💚 Build Succeeded
History
|
|
Will finalize the review on monday, but starting this up from draft to trigger a few more CI jobs |

Proposed commit message
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots