Skip to content

[hackerone] Initial release of HackerOne with Report data streams#18951

Open
clement-fouque wants to merge 34 commits into
elastic:mainfrom
clement-fouque:hackerone-new-integration-v5
Open

[hackerone] Initial release of HackerOne with Report data streams#18951
clement-fouque wants to merge 34 commits into
elastic:mainfrom
clement-fouque:hackerone-new-integration-v5

Conversation

@clement-fouque
Copy link
Copy Markdown
Contributor

Proposed commit message

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

Vale Linting Results

Summary: 9 warnings, 35 suggestions found

⚠️ Warnings (9)
File Line Rule Message
packages/hackerone/docs/README.md 116 Elastic.Latinisms Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'.
packages/hackerone/docs/README.md 116 Elastic.DontUse Don't use 'please'.
packages/hackerone/docs/README.md 359 Elastic.DontUse Don't use 'just'.
packages/hackerone/docs/README.md 375 Elastic.QuotesPunctuation Place punctuation inside closing quotation marks.
packages/hackerone/docs/README.md 375 Elastic.QuotesPunctuation Place punctuation inside closing quotation marks.
packages/hackerone/docs/README.md 488 Elastic.DontUse Don't use 'Thus'.
packages/hackerone/docs/README.md 510 Elastic.Latinisms Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'.
packages/hackerone/docs/README.md 510 Elastic.DontUse Don't use 'please'.
packages/hackerone/docs/README.md 754 Elastic.DontUse Don't use 'just'.
💡 Suggestions (35)
File Line Rule Message
packages/hackerone/_dev/build/docs/README.md 87 Elastic.WordChoice Consider using 'can, might' instead of 'may', unless the term is in the UI.
packages/hackerone/_dev/build/docs/README.md 93 Elastic.Semicolons Use semicolons judiciously.
packages/hackerone/docs/README.md 88 Elastic.WordChoice Consider using 'can, might' instead of 'may', unless the term is in the UI.
packages/hackerone/docs/README.md 94 Elastic.Semicolons Use semicolons judiciously.
packages/hackerone/docs/README.md 106 Elastic.WordChoice Consider using 'can, might' instead of 'may', unless the term is in the UI.
packages/hackerone/docs/README.md 114 Elastic.Wordiness Consider using 'tell' instead of 'inform'.
packages/hackerone/docs/README.md 114 Elastic.WordChoice Consider using 'can, might' instead of 'may', unless the term is in the UI.
packages/hackerone/docs/README.md 114 Elastic.WordChoice Consider using 'can, might' instead of 'may', unless the term is in the UI.
packages/hackerone/docs/README.md 116 Elastic.WordChoice Consider using 'can, might' instead of 'may', unless the term is in the UI.
packages/hackerone/docs/README.md 116 Elastic.WordChoice Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI.
packages/hackerone/docs/README.md 117 Elastic.WordChoice Consider using 'efficiently' instead of 'simply', unless the term is in the UI.
packages/hackerone/docs/README.md 117 Elastic.WordChoice Consider using 'can, might' instead of 'may', unless the term is in the UI.
packages/hackerone/docs/README.md 124 Elastic.Clone Use cloning only when referring to cloning a GitHub repository or creating a copy that is linked to the original. Often confused with 'copy' and 'duplicate'.
packages/hackerone/docs/README.md 227 Elastic.WordChoice Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI.
packages/hackerone/docs/README.md 242 Elastic.WordChoice Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI.
packages/hackerone/docs/README.md 259 Elastic.WordChoice Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI.
packages/hackerone/docs/README.md 326 Elastic.WordChoice Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI.
packages/hackerone/docs/README.md 336 Elastic.WordChoice Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI.
packages/hackerone/docs/README.md 359 Elastic.WordChoice Consider using 'can, might' instead of 'may', unless the term is in the UI.
packages/hackerone/docs/README.md 500 Elastic.WordChoice Consider using 'can, might' instead of 'may', unless the term is in the UI.
packages/hackerone/docs/README.md 508 Elastic.Wordiness Consider using 'tell' instead of 'inform'.
packages/hackerone/docs/README.md 508 Elastic.WordChoice Consider using 'can, might' instead of 'may', unless the term is in the UI.
packages/hackerone/docs/README.md 508 Elastic.WordChoice Consider using 'can, might' instead of 'may', unless the term is in the UI.
packages/hackerone/docs/README.md 510 Elastic.WordChoice Consider using 'can, might' instead of 'may', unless the term is in the UI.
packages/hackerone/docs/README.md 510 Elastic.WordChoice Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI.
packages/hackerone/docs/README.md 511 Elastic.WordChoice Consider using 'efficiently' instead of 'simply', unless the term is in the UI.
packages/hackerone/docs/README.md 511 Elastic.WordChoice Consider using 'can, might' instead of 'may', unless the term is in the UI.
packages/hackerone/docs/README.md 518 Elastic.Clone Use cloning only when referring to cloning a GitHub repository or creating a copy that is linked to the original. Often confused with 'copy' and 'duplicate'.
packages/hackerone/docs/README.md 621 Elastic.WordChoice Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI.
packages/hackerone/docs/README.md 636 Elastic.WordChoice Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI.
packages/hackerone/docs/README.md 653 Elastic.WordChoice Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI.
packages/hackerone/docs/README.md 720 Elastic.WordChoice Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI.
packages/hackerone/docs/README.md 730 Elastic.WordChoice Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI.
packages/hackerone/docs/README.md 754 Elastic.WordChoice Consider using 'can, might' instead of 'may', unless the term is in the UI.
packages/hackerone/docs/README.md 793 Elastic.WordChoice Consider using 'can, might' instead of 'may', unless the term is in the UI.

The Vale linter checks documentation changes against the Elastic Docs style guide.

To use Vale locally or report issues, refer to Elastic style guide for Vale.

@clement-fouque
Copy link
Copy Markdown
Contributor Author

@efd6 can you perform a review of the CEL part? Thanks.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Comment thread packages/hackerone/data_stream/report/agent/stream/cel.yml.hbs Outdated
Comment thread packages/hackerone/data_stream/report/agent/stream/cel.yml.hbs Outdated
Comment thread packages/hackerone/data_stream/report/agent/stream/cel.yml.hbs Outdated
Comment thread packages/hackerone/data_stream/report/agent/stream/cel.yml.hbs Outdated
Comment thread packages/hackerone/data_stream/report/agent/stream/cel.yml.hbs Outdated
Comment thread packages/hackerone/data_stream/report/agent/stream/cel.yml.hbs Outdated
Comment thread packages/hackerone/data_stream/report/agent/stream/cel.yml.hbs Outdated
Comment thread packages/hackerone/data_stream/report/agent/stream/cel.yml.hbs Outdated
Comment thread packages/hackerone/data_stream/report/agent/stream/cel.yml.hbs Outdated
Comment thread packages/hackerone/data_stream/report/agent/stream/cel.yml.hbs Outdated
@andrewkroh andrewkroh added New Integration Issue or pull request for creating a new integration package. documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. labels May 12, 2026
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

elastic-vault-github-plugin-prod Bot commented May 12, 2026

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@clement-fouque clement-fouque force-pushed the hackerone-new-integration-v5 branch from 7ab7673 to 92037e3 Compare May 14, 2026 16:18
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@clement-fouque clement-fouque force-pushed the hackerone-new-integration-v5 branch from d394b3e to ce28db2 Compare May 14, 2026 16:38
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

clement-fouque and others added 7 commits May 19, 2026 15:16
Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Copy Markdown
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CEL code LGTM

Comment thread packages/hackerone/data_stream/report/agent/stream/cel.yml.hbs Outdated
@github-actions
Copy link
Copy Markdown
Contributor

TL;DR

Check integrations netbox failed, but the provided Buildkite log is truncated to teardown/output-upload lines and does not include the first failing command or assertion. Immediate action: re-run that job with full step log retention (or share the uploaded build/test-results/netbox-system-*.xml) so the exact failing test can be identified.

Remediation

  • Re-run Check integrations netbox and capture the full step output from the first failure line (not just the teardown tail).
  • Inspect/upload build/test-results/netbox-system-*.xml from that run; this should contain the failing test name and assertion message.
  • If the rerun passes without code changes, classify as transient infrastructure/test flake and retry CI.
Investigation details

Root Cause

The root cause is not identifiable from the available log artifact. The only captured lines are stack teardown and artifact upload, followed by a generic non-zero exit.

Evidence

  • Build: https://buildkite.com/elastic/integrations/builds/43133
  • Job/step: Check integrations netbox
  • Key log excerpt (/tmp/gh-aw/buildkite-logs/integrations-check-integrations-netbox.txt):
    • --- [netbox] failed (line 73)
    • 🚨 Error: The command exited with status 1 (line 76)
    • user command error: exit status 1 (line 78)
    • No earlier test/assertion output present in this file.
  • Uploaded artifacts listed in the same log include build/test-results/netbox-system-*.xml, indicating likely useful failure details exist outside the provided excerpt.
  • PR diff checked locally at commit d2cd987a65f6067e9387ed2e73d530c90477c1c5: changes are under packages/hackerone/** (plus .github/CODEOWNERS), with no direct packages/netbox/** edits.

Verification

  • Not run in this environment: reproducing .buildkite/scripts/test_one_package.sh depends on Buildkite runtime env/config and failed early here due missing pipeline env (YQ_VERSION unset).

Follow-up

Share the failing netbox-system xUnit XML (or full pre-teardown job logs) and I can provide a precise root-cause + patch-level remediation.

Note

🔒 Integrity filter blocked 2 items

The following items were blocked because they don't meet the GitHub integrity level.

To allow these resources, lower min-integrity in your GitHub frontmatter:

tools:
  github:
    min-integrity: approved  # merged | approved | unapproved | none

What is this? | From workflow: PR Buildkite Detective

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

Comment thread packages/hackerone/data_stream/report/fields/ecs.yml Outdated
Comment on lines +34 to +44
description: |-
Program handles to restrict results (`filter[program][]`).
Provide at least one program handle **or** one inbox id — the API requires one scope filter.
multi: true
required: false
show_user: true
- name: inbox_ids
type: text
title: Inbox IDs
description: |-
Inbox identifiers (`filter[inbox_ids][]`). At least one program handle **or** one inbox id is required by the API.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this work? I don't really understand the format the user has to provide this in. You could possibly have a default value but have it commented out?

If these are an array of just values, its better that we just ask them to give us a list of values as for example type text and multi true, then build the array in the configuration itself?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how it looks like.
image

Comment thread packages/hackerone/data_stream/report/manifest.yml Outdated
Comment thread packages/hackerone/data_stream/report/agent/stream/cel.yml.hbs
Comment thread packages/hackerone/data_stream/report/elasticsearch/ingest_pipeline/default.yml Outdated
…product, and vulnerability.scanner.vendor in ecs.yml
…clarity and consistency. Updated mappings for event ID, vulnerability details, user information, and organization attributes to use 'rename' instead of 'set' for better alignment with ECS standards.
@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

History

@P1llus P1llus marked this pull request as ready for review May 22, 2026 15:55
@P1llus P1llus requested a review from a team as a code owner May 22, 2026 15:55
@P1llus
Copy link
Copy Markdown
Member

P1llus commented May 22, 2026

Will finalize the review on monday, but starting this up from draft to trigger a few more CI jobs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. New Integration Issue or pull request for creating a new integration package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants