Skip to content

crowdstrike: remove incorrect no-limit max_executions documentation#19809

Merged
efd6 merged 1 commit into
elastic:mainfrom
efd6:19762-crowdstrike
Jun 29, 2026
Merged

crowdstrike: remove incorrect no-limit max_executions documentation#19809
efd6 merged 1 commit into
elastic:mainfrom
efd6:19762-crowdstrike

Conversation

@efd6

@efd6 efd6 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Proposed commit message

crowdstrike: remove incorrect no-limit max_executions documentation

In the alert, host, indentity_protection_assessment,
indentity_protection_timeline and vulnerability, the number of CEL
executions allowed for each periodic evaluation can be configured. The
documentation in the user interface says that this limit can be lifted
if it is set to zero. This is not the case, by design. So remove the
statement.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Jun 29, 2026
@efd6 efd6 added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:crowdstrike CrowdStrike bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Jun 29, 2026
In the alert, host, indentity_protection_assessment,
indentity_protection_timeline and vulnerability, the number of CEL
executions allowed for each periodic evaluation can be configured. The
documentation in the user interface says that this limit can be lifted
if it is set to zero. This is not the case, by design. So remove the
statement.
@efd6 efd6 force-pushed the 19762-crowdstrike branch from 78d168b to a1f4023 Compare June 29, 2026 00:08
@github-actions

Copy link
Copy Markdown
Contributor

Elastic Docs Style Checker (Vale)

Summary: 5 suggestions found

💡 Suggestions (5): Optional style improvements. Apply when helpful.
File Line Rule Message
packages/crowdstrike/data_stream/alert/manifest.yml 62 Elastic.WordChoice Consider using 'can, might' instead of 'may', unless the term is in the UI.
packages/crowdstrike/data_stream/host/manifest.yml 78 Elastic.WordChoice Consider using 'can, might' instead of 'may', unless the term is in the UI.
packages/crowdstrike/data_stream/identity_protection_assessment/manifest.yml 55 Elastic.WordChoice Consider using 'can, might' instead of 'may', unless the term is in the UI.
packages/crowdstrike/data_stream/identity_protection_timeline/manifest.yml 61 Elastic.WordChoice Consider using 'can, might' instead of 'may', unless the term is in the UI.
packages/crowdstrike/data_stream/vulnerability/manifest.yml 73 Elastic.WordChoice Consider using 'can, might' instead of 'may', unless the term is in the UI.

The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale.

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown

✅ All changelog entries have the correct PR link.

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

💚 Build Succeeded

cc @efd6

@efd6 efd6 marked this pull request as ready for review June 29, 2026 01:51
@efd6 efd6 requested review from a team as code owners June 29, 2026 01:51
@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@vera-review-bot

Copy link
Copy Markdown

👀 I have started reviewing the PR

@vera-review-bot

Copy link
Copy Markdown

Vera Review Bot

For the current commit state, I did not find any issues.


🤖 AI-Generated Review | Vera Review Bot | 📚 Knowledge base: integration-skills

⚠️ Automated review — verify suggestions before applying.

@mergify

mergify Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@efd6 efd6 merged commit 7c6e939 into elastic:main Jun 29, 2026
9 checks passed
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown

Package crowdstrike - 3.26.1 containing this change is available at https://epr.elastic.co/package/crowdstrike/3.26.1/

@andrewkroh andrewkroh removed the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:crowdstrike CrowdStrike Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CrowdStrike]: Setting max_executions to 0 for unlimited fails

3 participants