crowdstrike: fix streaming system test mock to handle reconnection with offset#19810
Merged
Conversation
…th offset The streaming input appends ?offset=N to the feed URL when reconnecting after a stream ends. The mock server only had a rule for /events with no query parameters (offset: null), so reconnection requests got 404, causing the agent to go DEGRADED and failing the system test. Add a catch-all /events rule (without query_params constraints) after the existing rule. It matches reconnection requests and returns an empty 200, preventing the DEGRADED transition. Fixes elastic#19766 Fixes elastic#19773
efd6
added
Integration:crowdstrike
efd6
changed the title
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
cc @efd6 |
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
|
👀 I have started reviewing the PR |
Vera Review BotFor the current commit state, I did not find any issues. 🤖 AI-Generated Review | Vera Review Bot | 📚 Knowledge base: integration-skills
|
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Note
Not user-facing, so no changelog.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots