Skip to content

lastpass: use explicit JSON serialisation in response transform#19811

Merged
efd6 merged 1 commit into
elastic:mainfrom
efd6:not_mapstr_workaround
Jun 30, 2026
Merged

lastpass: use explicit JSON serialisation in response transform#19811
efd6 merged 1 commit into
elastic:mainfrom
efd6:not_mapstr_workaround

Conversation

@efd6

@efd6 efd6 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Proposed commit message

lastpass: use explicit JSON serialisation in response transform

A Beats regression (elastic/beats#50384) changed response body
template values from mapstr.M (whose String method produces JSON)
to plain map[string]interface{} (whose String method produces Go
map syntax). This breaks the detailed_shared_folder response
transform which renders the whole body with value_type: json.

Use the toJSON template function to serialise the body explicitly,
bypassing the implicit serialisation path.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Jun 29, 2026
@efd6 efd6 added Integration:lastpass LastPass bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Jun 29, 2026
@efd6
lastpass: use explicit JSON serialisation in response transform
b81bf88 
A Beats regression (elastic/beats#50384) changed response body
template values from mapstr.M (whose String method produces JSON)
to plain map[string]interface{} (whose String method produces Go
map syntax). This breaks the detailed_shared_folder response
transform which renders the whole body with value_type: json.

Use the toJSON template function to serialise the body explicitly,
bypassing the implicit serialisation path.

Updates elastic#18754
Updates elastic#19767
Updates elastic#19774
@efd6 efd6 force-pushed the not_mapstr_workaround branch from 9d236c5 to b81bf88 Compare June 29, 2026 01:31
@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

✅ Elastic Docs Style Checker (Vale)

No issues found on modified lines!

The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale.

@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Jun 29, 2026

Copy link
Copy Markdown

✅ All changelog entries have the correct PR link.

@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Jun 29, 2026

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@infra-vault-gh-plugin-prod

infra-vault-gh-plugin-prod Bot commented Jun 29, 2026

Copy link
Copy Markdown

💚 Build Succeeded

cc @efd6

@efd6 efd6 marked this pull request as ready for review June 29, 2026 01:59
@efd6 efd6 requested review from a team as code owners June 29, 2026 01:59
@infra-vault-gh-plugin-prod

infra-vault-gh-plugin-prod Bot commented Jun 29, 2026

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@vera-review-bot

vera-review-bot Bot commented Jun 29, 2026

Copy link
Copy Markdown

👀 I have started reviewing the PR

@vera-review-bot

vera-review-bot Bot commented Jun 29, 2026

Copy link
Copy Markdown

Vera Review Bot

For the current commit state, I did not find any issues.

🤖 AI-Generated Review | Vera Review Bot | 📚 Knowledge base: integration-skills

⚠️ Automated review — verify suggestions before applying.

@mergify

mergify Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@efd6 efd6 merged commit c9314c8 into elastic:main Jun 30, 2026
9 checks passed
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Jun 30, 2026

Copy link
Copy Markdown

Package lastpass - 1.23.1 containing this change is available at https://epr.elastic.co/package/lastpass/1.23.1/

This was referenced Jul 1, 2026
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kcreddy kcreddy kcreddy approved these changes

Assignees

@efd6 efd6

Labels

bugfix Pull request that fixes a bug issue Integration:lastpass LastPass Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@efd6 @kcreddy