[netbox] Add missing default for disable_keep_alive var#19889
Merged
andrewkroh merged 1 commit intoJul 2, 2026
Conversation
Contributor
✅ Elastic Docs Style Checker (Vale)No issues found on modified lines! The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
andrewkroh
force-pushed
the
netbox/fix/missing-var-policy-template
branch
2 times, most recently
from
64c4184 to
0121132
Compare
andrewkroh
changed the title
The disable_keep_alive variable in the httpjson input was declared as required: true and show_user: false but with no default value. Because the variable is hidden from the user and the system tests do not supply it explicitly, Fleet rejects the package policy with: inputs.httpjson.vars.disable_keep_alive: ["Disable HTTP Keep-Alives is required"] Add default: false (the canonical pattern used by okta and 1password) so Fleet can satisfy the required constraint without user input. Closes elastic#18665, elastic#18666, elastic#18667, elastic#18668, elastic#18727, elastic#18728
andrewkroh
force-pushed
the
netbox/fix/missing-var-policy-template
branch
from
0121132 to
650b853
Compare
andrewkroh
added
Integration:netbox
Contributor
|
✅ All changelog entries have the correct PR link. |
Contributor
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
|
5 tasks
ishleenk17
approved these changes
Jul 2, 2026
Contributor
|
Package netbox - 0.1.1 containing this change is available at https://epr.elastic.co/package/netbox/0.1.1/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Assisted-by: Claude Opus 4.8 (planning) and Sonnet 4.6.
Checklist
changelog.ymlfile.Author's Checklist
netbox.devicesandnetbox.ipssystem tests pass locally after the fix.How to test this PR locally
Both data streams should show PASS. Before the fix both fail at policy creation with the
disable_keep_alive is requirederror.Related issues
disable_keep_aliveto false #18679 (didn't see this one until Mario linked it)