[sailpoint_identity_sc] Add machine_identities data stream#20198
Open
chemamartinez wants to merge 2 commits into
Open
[sailpoint_identity_sc] Add machine_identities data stream#20198chemamartinez wants to merge 2 commits into
chemamartinez wants to merge 2 commits into
Conversation
chemamartinez
added
enhancement
chemamartinez
marked this pull request as ready for review
July 17, 2026 18:06
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
Contributor
Elastic Docs Style Checker (Vale)Summary: 2 warnings found
|
| File | Line | Rule | Message |
|---|---|---|---|
| packages/sailpoint_identity_sc/_dev/build/docs/README.md | 59 | Elastic.DontUse | Don't use 'Please'. |
| packages/sailpoint_identity_sc/manifest.yml | 59 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale.
Contributor
|
✅ All changelog entries have the correct PR link. |
|
|
Contributor
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
|
andrewkroh
added
documentation
efd6
reviewed
Jul 19, 2026
| "events": { | ||
| "error": { | ||
| "code": string(resp.StatusCode), | ||
| "id": string(resp.Status), |
Contributor
There was a problem hiding this comment.
Suggested change
| "id": string(resp.Status), | |
| "id": resp.Status, |
| (size(resp.Body) != 0) ? | ||
| string(resp.Body) | ||
| : | ||
| string(resp.Status) + " (" + string(resp.StatusCode) + ")" |
Contributor
There was a problem hiding this comment.
Suggested change
| string(resp.Status) + " (" + string(resp.StatusCode) + ")" | |
| resp.Status + " (" + string(resp.StatusCode) + ")" |
| - "sp:search:read" | ||
| - "idn:mis-identity:read" | ||
| - "idn:mis-identity:manage" | ||
| - name: enable_request_tracer |
Contributor
There was a problem hiding this comment.
Can we move this to the data stream level? Maybe in a follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
changelog.ymlfile.Related issues
Screenshots