[ti_abusech] Add Commercial API support for MalwareBazaar data streams#20199
Open
moxarth-rathod wants to merge 2 commits into
Open
[ti_abusech] Add Commercial API support for MalwareBazaar data streams#20199moxarth-rathod wants to merge 2 commits into
moxarth-rathod wants to merge 2 commits into
Conversation
moxarth-rathod
added
enhancement
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
Contributor
Elastic Docs Style Checker (Vale)Summary: 4 suggestions found 💡 Suggestions (4): Optional style improvements. Apply when helpful.
The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
Contributor
|
✅ All changelog entries have the correct PR link. |
|
|
Contributor
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
|
efd6
reviewed
Jul 19, 2026
| }, | ||
| "want_more": false, | ||
| } | ||
| : has(state.token) && has(state.token.access_token) && has(state.token.expires) && now() < timestamp(int(state.token.expires) - 60) ? |
Contributor
There was a problem hiding this comment.
Suggested change
| : has(state.token) && has(state.token.access_token) && has(state.token.expires) && now() < timestamp(int(state.token.expires) - 60) ? | |
| : has(state.?token.access_token) && has(state.?token.expires) && now() < timestamp(int(state.token.expires) - 60) ? |
| "events": { | ||
| "error": { | ||
| "code": string(auth_resp.StatusCode), | ||
| "id": string(auth_resp.Status), |
Contributor
There was a problem hiding this comment.
Suggested change
| "id": string(auth_resp.Status), | |
| "id": auth_resp.Status, |
| size(auth_resp.Body) != 0 ? | ||
| string(auth_resp.Body) | ||
| : | ||
| string(auth_resp.Status) + " (" + string(auth_resp.StatusCode) + ")" |
Contributor
There was a problem hiding this comment.
Suggested change
| string(auth_resp.Status) + " (" + string(auth_resp.StatusCode) + ")" | |
| auth_resp.Status + " (" + string(auth_resp.StatusCode) + ")" |
| ) | ||
| ).as(token, !has(token.access_token) ? token : | ||
| ( | ||
| has(state.cursor) && has(state.cursor.after) ? |
Contributor
There was a problem hiding this comment.
Suggested change
| has(state.cursor) && has(state.cursor.after) ? | |
| has(state.?cursor.after) ? |
but why are we checking for the presence of state.cursor.after and then using state.cursor.since?
| "events": body.items.map(ind, { | ||
| "message": ind.encode_json(), | ||
| }), | ||
| "want_more": has(body.meta) && has(body.meta.next_cursor), |
Contributor
There was a problem hiding this comment.
Suggested change
| "want_more": has(body.meta) && has(body.meta.next_cursor), | |
| "want_more": has(body.?meta.next_cursor), |
| size(resp.Body) != 0 ? | ||
| string(resp.Body) | ||
| : | ||
| string(resp.Status) + ' (' + string(resp.StatusCode) + ')' |
Contributor
There was a problem hiding this comment.
Suggested change
| string(resp.Status) + ' (' + string(resp.StatusCode) + ')' | |
| resp.Status + ' (' + string(resp.StatusCode) + ')' |
| ?"id": body.?query_status, | ||
| "message": "POST "+state.url+": "+( | ||
| "code": string(resp.StatusCode), | ||
| "id": string(resp.Status), |
Contributor
There was a problem hiding this comment.
Suggested change
| "id": string(resp.Status), | |
| "id": resp.Status, |
Comment on lines
+7
to
+8
| event.ingested: ".*" | ||
| abusech.malwarebazaar.deleted_at: ".*" |
Contributor
There was a problem hiding this comment.
There is no sample event from the system tests. Can you add this?
| { | ||
| "code": 200, | ||
| "token": "test-commercial-token", | ||
| "expires": 4102444800 |
Contributor
There was a problem hiding this comment.
January 1, 2100 for never expires? Has this been tested against a real endpoint so that we know the token requests work?
Alternatively, add a script test for this.
andrewkroh
added
the
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
changelog.ymlfile.How to test this PR locally
Related issues