Add deployer setting to system test configuration (#1104)

Add the validation of the deployer setting into the system test configuration
file spec, as it was done for the benchmark system configuration files.

Author: mrodm

code/go/pkg/validator/validator_test.go

@@ -517,6 +517,12 @@ func TestValidateFile(t *testing.T) {
 				"field deployer: deployer must be one of the following: \"docker\", \"tf\", \"k8s\"",
 			},
 		},
+		"bad_deployer_system_test": {
+			"data_stream/foo/_dev/test/system/test-default-config.yml",
+			[]string{
+				"field deployer: deployer must be one of the following: \"docker\", \"tf\", \"k8s\"",
+			},
+		},
 	}
 
 	for pkgName, test := range tests {

spec/changelog.yml

@@ -64,6 +64,9 @@
     - description: Add support for `profiles` policy template type in input packages
       type: enhancement
       link: https://github.com/elastic/package-spec/pull/1092
+    - description: Add deployer option to system test configuration.
+      type: enhancement
+      link: https://github.com/elastic/package-spec/pull/1104
 - version: 3.5.7
   changes:
     - description: Allow _dev directory for content-only packages; use _dev/shared for development files (e.g. dashboard YML sources).

spec/integration/_dev/benchmark/system.scenario.spec.yml

@@ -49,13 +49,6 @@ spec:
       type: string
       default: 10m
       example: 10m
-    deployer:
-      description: Name of the service deployer to setup for this system benchmark.
-      type: string
-      enum:
-        - docker
-        - tf
-        - k8s
     corpora:
       description: Corpora settings.
       type: object
@@ -161,6 +154,6 @@ spec:
     wait_for_data_timeout:
       $ref: "#/definitions/wait_for_data_timeout"
     deployer:
-      $ref: "#/definitions/deployer"
+      $ref: "../../data_stream/_dev/test/config.spec.yml#/definitions/deployer"
     corpora:
       $ref: "#/definitions/corpora"

spec/integration/data_stream/_dev/test/config.spec.yml

@@ -6,6 +6,13 @@ spec:
   type: object
   additionalProperties: false
   definitions:
+    deployer:
+      description: Name of the service deployer to setup for this system benchmark.
+      type: string
+      enum:
+        - docker
+        - tf
+        - k8s
     skip:
       description: If this test should be skipped, more information about why it was skipped.
       type: object

spec/integration/data_stream/_dev/test/system/config.spec.yml

@@ -5,6 +5,8 @@ spec:
   # Everything under here follows JSON schema (https://json-schema.org/), written as YAML for readability
   type: object
   properties:
+    deployer:
+      $ref: "./../config.spec.yml#/definitions/deployer"
     skip:
       $ref: "./../config.spec.yml#/definitions/skip"
     wait_for_data_timeout:

test/packages/bad_deployer_system_test/LICENSE.txt

@@ -0,0 +1,93 @@
+Elastic License 2.0
+
+URL: https://www.elastic.co/licensing/elastic-license
+
+## Acceptance
+
+By using the software, you agree to all of the terms and conditions below.
+
+## Copyright License
+
+The licensor grants you a non-exclusive, royalty-free, worldwide,
+non-sublicensable, non-transferable license to use, copy, distribute, make
+available, and prepare derivative works of the software, in each case subject to
+the limitations and conditions below.
+
+## Limitations
+
+You may not provide the software to third parties as a hosted or managed
+service, where the service provides users with access to any substantial set of
+the features or functionality of the software.
+
+You may not move, change, disable, or circumvent the license key functionality
+in the software, and you may not remove or obscure any functionality in the
+software that is protected by the license key.
+
+You may not alter, remove, or obscure any licensing, copyright, or other notices
+of the licensor in the software. Any use of the licensor’s trademarks is subject
+to applicable law.
+
+## Patents
+
+The licensor grants you a license, under any patent claims the licensor can
+license, or becomes able to license, to make, have made, use, sell, offer for
+sale, import and have imported the software, in each case subject to the
+limitations and conditions in this license. This license does not cover any
+patent claims that you cause to be infringed by modifications or additions to
+the software. If you or your company make any written claim that the software
+infringes or contributes to infringement of any patent, your patent license for
+the software granted under these terms ends immediately. If your company makes
+such a claim, your patent license ends immediately for work on behalf of your
+company.
+
+## Notices
+
+You must ensure that anyone who gets a copy of any part of the software from you
+also gets a copy of these terms.
+
+If you modify the software, you must include in any modified copies of the
+software prominent notices stating that you have modified the software.
+
+## No Other Rights
+
+These terms do not imply any licenses other than those expressly granted in
+these terms.
+
+## Termination
+
+If you use the software in violation of these terms, such use is not licensed,
+and your licenses will automatically terminate. If the licensor provides you
+with a notice of your violation, and you cease all violation of this license no
+later than 30 days after you receive that notice, your licenses will be
+reinstated retroactively. However, if you violate these terms after such
+reinstatement, any additional violation of these terms will cause your licenses
+to terminate automatically and permanently.
+
+## No Liability
+
+*As far as the law allows, the software comes as is, without any warranty or
+condition, and the licensor will not be liable to you for any damages arising
+out of these terms or the use or nature of the software, under any kind of
+legal claim.*
+
+## Definitions
+
+The **licensor** is the entity offering these terms, and the **software** is the
+software the licensor makes available under these terms, including any portion
+of it.
+
+**you** refers to the individual or entity agreeing to these terms.
+
+**your company** is any legal entity, sole proprietorship, or other kind of
+organization that you work for, plus all organizations that have control over,
+are under the control of, or are under common control with that
+organization. **control** means ownership of substantially all the assets of an
+entity, or the power to direct its management and policies by vote, contract, or
+otherwise. Control can be direct or indirect.
+
+**your licenses** are all the licenses granted to you for the software under
+these terms.
+
+**use** means anything you do with the software requiring one of your licenses.
+
+**trademark** means trademarks, service marks, and similar rights.

test/packages/bad_deployer_system_test/changelog.yml

@@ -0,0 +1,6 @@
+# newer versions go on top
+- version: "0.0.1"
+  changes:
+    - description: Initial draft of the package
+      type: enhancement
+      link: https://github.com/elastic/integrations/pull/1 # FIXME Replace with the real PR link

test/packages/bad_deployer_system_test/data_stream/foo/_dev/test/system/test-default-config.yml

@@ -0,0 +1,2 @@
+deployer: invaliddeployer
+vars: ~

test/packages/bad_deployer_system_test/data_stream/foo/agent/stream/filestream.yml.hbs

@@ -0,0 +1,44 @@
+paths:
+{{#each paths as |path|}}
+  - {{path}}
+{{/each}}
+{{#if exclude_files}}
+prospector.scanner.exclude_files:
+{{#each exclude_files as |pattern f|}}
+  - {{pattern}}
+{{/each}}
+{{/if}}
+{{#if multiline_json}}
+multiline.pattern: '^{'
+multiline.negate: true
+multiline.match: after
+multiline.max_lines: 5000
+multiline.timeout: 10
+{{/if}}
+{{#if custom}}
+{{custom}}
+{{/if}}
+
+{{#if tags.length}}
+tags:
+{{#each tags as |tag|}}
+- {{tag}}
+{{/each}}
+{{#if preserve_original_event}}
+- preserve_original_event
+{{/if}}
+{{else}}
+{{#if preserve_original_event}}
+tags:
+- preserve_original_event
+{{/if}}
+
+{{#contains "forwarded" tags}}
+publisher_pipeline.disable_host: true
+{{/contains}}
+
+{{#if processors}}
+processors:
+{{processors}}
+{{/if}}
+{{/if}}

test/packages/bad_deployer_system_test/data_stream/foo/elasticsearch/ingest_pipeline/default.yml

@@ -0,0 +1,10 @@
+---
+description: Pipeline for processing sample logs
+processors:
+- set:
+    field: sample_field
+    value: "1"
+on_failure:
+- set:
+    field: error.message
+    value: '{{ _ingest.on_failure_message }}'