Skip to content

Commit 8badee0

Browse files
committed
Clear TODO Comments
1 parent 1b2a728 commit 8badee0

1 file changed

Lines changed: 4 additions & 5 deletions

File tree

.github/workflows/end-to-end.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@ on:
44
schedule:
55
- cron: "0 4 * * *"
66

7-
# TODO: Use workflow dispatch for testing manually. Should only enable schedule run when merging the PR
8-
# on:
7+
# TODO: Use workflow dispatch for testing manually. Can be removed before merging the PR
98
workflow_dispatch:
109
inputs:
1110
environment:
@@ -498,7 +497,6 @@ jobs:
498497

499498
- name: Run end-to-end tests
500499
continue-on-error: true
501-
# if: steps.wait-wc.outcome == 'success'
502500
id: e2e-test
503501
run: ./apps/pipeline/test/end-to-end.bash
504502

@@ -616,11 +614,12 @@ jobs:
616614
GITHUB_ACTOR: ${{ github.actor }}
617615
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
618616

619-
# TODO: Alert run with condition github.event.inputs.alerts == 'true' should be changed to always() when PR is ready to merge
617+
# TODO: alert job condition should be changed to always() before PR is merged
620618
alert:
621619
needs: [clean-apps-image]
622620
runs-on: ubuntu-latest
623-
# if: github.event.inputs.alerts == 'true' && github.ref == 'refs/heads/main'
621+
if: github.event.inputs.alerts == 'true' && github.ref == 'refs/heads/main' && github.workflow.on == 'workflow_dispatch'
622+
environment: test
624623
steps:
625624
- id: get-sha
626625
run: |

0 commit comments

Comments
 (0)