refactor: Add error trait bound to generic error type#6
Draft
krokosik wants to merge 2 commits into
Draft
Conversation
26cdaeb to
b8ea18c
Compare
Author
|
Okay, looks like my amateur Rust knowledge showed off ;// It seems that the |
b8ea18c to
6ba380b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for the great library! I would like to improve its error handling by adding the
Errortrait bound to your error type, so that it is compatible with crates such asanyhow. For example when I use the?operator in a function that returns ananyhow::ResultI have to appendmap_errto each method call.