chore(durable-streams-rust): rename folder, drop Intel macOS build, fix README#4656
Merged
Merged
Conversation
balegas
requested review from
KyleAMathews,
alco,
icehaunter,
kevin-dp,
magnetised,
msfstef,
paulharter,
robacourt,
samwillis and
thruflo
as code owners
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4656 +/- ##
=======================================
Coverage 60.00% 60.00%
=======================================
Files 395 395
Lines 43747 43747
Branches 12581 12580 -1
=======================================
Hits 26249 26249
Misses 17420 17420
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Electric Agents Mobile BuildLocal mobile checks ran for commit The EAS Android preview build was skipped because the |
balegas
force-pushed
the
vbalegas/server-rust-publish-no-macos13
branch
from
3fed9c8 to
70a2dcf
Compare
… fix README Rename packages/server-rust -> packages/durable-streams-server (npm package name, crate name, and binary name are unchanged, so publishing is unaffected). Update all path references in CI workflows, Dockerfile, npm templates, and the lockfile importer key. Drop the x86_64-apple-darwin (macos-13) leg from the publish build matrix: the scarce Intel macOS runner pool stalls releases, and its binary only feeds the disabled npm packages. Fix the README write-throughput figure (0.86M -> 860,000 append/s) and remove the per-stream results table. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
balegas
force-pushed
the
vbalegas/server-rust-publish-no-macos13
branch
from
70a2dcf to
bcc5b5d
Compare
balegas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Three related cleanups to the Rust Durable Streams server packaging:
packages/server-rust→packages/durable-streams-rust.macos-13) build from the publish matrix.Does this affect CI / publishing?
No — the rename is path-only. The npm package name (
@electric-ax/durable-streams-server-rust), the crate name (durable-streams), and the binary name (durable-streams-server) are all unchanged, so published artifacts and their consumers are unaffected. Updated every path reference:server_rust_tests,server_rust_publish,server_rust_dockerhub_image,changesets_release)DockerfileCOPY paths, npm package templates'repository.directory, conformance test commentspnpm-lock.yamlimporter key (regenerated viapnpm install --lockfile-only)pnpm-workspace.yamlglobspackages/*, so workspace resolution is transparent to the move.git mvpreserved file history (tracked as renames).Why drop macos-13
The Intel macOS runner pool is scarce and stalls releases (a publish run sat queued waiting for it). That binary only feeds the currently-disabled npm packages, so it's not on any shipping path today. Re-add it when npm publishing is re-enabled.
cargo-publishstays gated on thebuildjob, which now runs the two Linux targets plus the readily-available Apple-Siliconmacos-latest.README
~0.86M append/s→860,000 append/s; removed the per-stream results table (kept the prose summary).🤖 Generated with Claude Code