fix: replace certutil invocation with node native pfx parsing#32
Open
Agritite wants to merge 1 commit into
Open
fix: replace certutil invocation with node native pfx parsing#32Agritite wants to merge 1 commit into
Agritite wants to merge 1 commit into
Conversation
Agritite
commented
Apr 14, 2026
| }); | ||
|
|
||
| it('should return the publisher from the cert', async () => { | ||
| it('should return stdout when process succeeds', async () => { |
Author
There was a problem hiding this comment.
need to replace all tests of run because previously those were covered by testing certutil but now it's not.
Agritite
commented
Apr 14, 2026
| }) | ||
| } | ||
|
|
||
| export const exportedRunForVitest = run; |
Author
There was a problem hiding this comment.
suggestions welcome. I'm not a fan of this.
Author
|
rebased and signed |
Agritite
commented
Apr 15, 2026
| const pfx = await fs.promises.readFile(pfxPath); | ||
| return new Promise((resolve, reject) => { | ||
| // Windows pipe which is not persistent and will be deleted when process exits. See https://nodejs.org/api/net.html#identifying-paths-for-ipc-connections | ||
| const pipePath = path.win32.join('\\\\?', 'pipe', 'electron-windows-msix', crypto.randomUUID()); |
Author
There was a problem hiding this comment.
If electron-windows-msix would support cross building in the future, this will have to switch to domain socket path on posix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #26
Apparently node already has the ability to parse pkcs12 (
tls.createServeracceptspfx) but doesn't export such method innode:crypto. Luckily we can still make use of it by creating dummy tls connections.