Skip to content

fix: make reload menu items work with BaseWindow#51985

Merged
VerteDinde merged 1 commit into
mainfrom
nikwen/base-window-reload
Jun 25, 2026
Merged

fix: make reload menu items work with BaseWindow#51985
VerteDinde merged 1 commit into
mainfrom
nikwen/base-window-reload

Conversation

@nikwen

@nikwen nikwen commented Jun 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Description of Change

This PR makes the Ctrl+R and Ctrl+Shift+R shortcuts work in WebContentsViews that are added to BaseWindows.

Can be tested with this gist: https://gist.github.com/nikwen/d20a57fc1b0f0494ba32b80cffd4285f

Checklist

Release Notes

Notes: Made "reload" menu items work with BaseWindow.

@electron-cation electron-cation Bot added the new-pr 🌱 PR opened recently label Jun 13, 2026
@nikwen nikwen added target/41-x-y PR should also be added to the "41-x-y" branch. target/42-x-y PR should also be added to the "42-x-y" branch. target/43-x-y PR should also be added to the "43-x-y" branch. semver/patch backwards-compatible bug fixes labels Jun 13, 2026
@electron-cation electron-cation Bot removed the new-pr 🌱 PR opened recently label Jun 14, 2026
@VerteDinde VerteDinde merged commit 88cd4b4 into main Jun 25, 2026
89 checks passed
@VerteDinde VerteDinde deleted the nikwen/base-window-reload branch June 25, 2026 05:19
@release-clerk

release-clerk Bot commented Jun 25, 2026

Copy link
Copy Markdown

Release Notes Persisted

Made "reload" menu items work with BaseWindow.

@trop trop Bot mentioned this pull request Jun 25, 2026
Merged
@trop

trop Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

I have automatically backported this PR to "42-x-y", please check out #52117

@trop trop Bot mentioned this pull request Jun 25, 2026
Merged
@trop trop Bot removed the target/42-x-y PR should also be added to the "42-x-y" branch. label Jun 25, 2026
@trop trop Bot mentioned this pull request Jun 25, 2026
Merged
@trop

trop Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

I have automatically backported this PR to "41-x-y", please check out #52118

@trop

trop Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

I have automatically backported this PR to "43-x-y", please check out #52119

@trop trop Bot added in-flight/41-x-y in-flight/43-x-y merged/43-x-y PR was merged to the "43-x-y" branch. merged/42-x-y PR was merged to the "42-x-y" branch. merged/41-x-y PR was merged to the "41-x-y" branch. and removed target/41-x-y PR should also be added to the "41-x-y" branch. target/43-x-y PR should also be added to the "43-x-y" branch. in-flight/43-x-y in-flight/42-x-y in-flight/41-x-y labels Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees

No one assigned

Labels

merged/41-x-y PR was merged to the "41-x-y" branch. merged/42-x-y PR was merged to the "42-x-y" branch. merged/43-x-y PR was merged to the "43-x-y" branch. semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nikwen @VerteDinde