test: use overridePlatform util (#1347)

Author: dsanders11

tests/main/first-run-spec.ts

@@ -6,6 +6,7 @@ import { app, dialog } from 'electron';
 
 import { onFirstRunMaybe } from '../../src/main/first-run';
 import { isFirstRun } from '../../src/utils/check-first-run';
+import { overridePlatform, resetPlatform } from '../utils';
 
 jest.mock('../../src/utils/check-first-run', () => ({
   isFirstRun: jest.fn(),
@@ -17,22 +18,17 @@ const mockDialogResponse = {
 
 describe('first-run', () => {
   const oldDefaultApp = process.defaultApp;
-  const oldPlatform = process.platform;
 
   beforeEach(() => {
-    Object.defineProperty(process, 'platform', {
-      value: 'darwin',
-    });
+    overridePlatform('darwin');
 
     (dialog.showMessageBox as jest.Mock<any>).mockResolvedValue(
       mockDialogResponse,
     );
   });
 
   afterEach(() => {
-    Object.defineProperty(process, 'platform', {
-      value: oldPlatform,
-    });
+    resetPlatform();
   });
 
   afterEach(() => {
@@ -65,9 +61,7 @@ describe('first-run', () => {
     });
 
     it(`doesn't run unless required (Windows, Linux)`, () => {
-      Object.defineProperty(process, 'platform', {
-        value: 'win32',
-      });
+      overridePlatform('win32');
 
       (isFirstRun as jest.Mock).mockReturnValueOnce(true);
       (app.isInApplicationsFolder as jest.Mock).mockReturnValue(false);

tests/main/main-spec.ts

@@ -20,7 +20,7 @@ import { shouldQuit } from '../../src/main/squirrel';
 import { setupUpdates } from '../../src/main/update';
 import { getOrCreateMainWindow } from '../../src/main/windows';
 import { BrowserWindowMock } from '../mocks/browser-window';
-import { overridePlatform } from '../utils';
+import { overridePlatform, resetPlatform } from '../utils';
 
 jest.mock('../../src/main/windows', () => ({
   getOrCreateMainWindow: jest.fn(),
@@ -47,18 +47,12 @@ jest.mock('../../src/main/ipc');
  * for CI to know that the app is still opening a window.
  */
 describe('main', () => {
-  const oldPlatform = process.platform;
-
   beforeAll(() => {
-    Object.defineProperty(process, 'platform', {
-      value: 'win32',
-    });
+    overridePlatform('win32');
   });
 
   afterAll(() => {
-    Object.defineProperty(process, 'platform', {
-      value: oldPlatform,
-    });
+    resetPlatform();
   });
 
   beforeEach(() => {
@@ -109,9 +103,7 @@ describe('main', () => {
     });
 
     it('does not quit the app on macOS', () => {
-      Object.defineProperty(process, 'platform', {
-        value: 'darwin',
-      });
+      overridePlatform('darwin');
 
       onWindowsAllClosed();
 

tests/utils/exec-spec.ts

@@ -1,11 +1,11 @@
+import { overridePlatform, resetPlatform } from '../utils';
+
 jest.mock('child_process');
 
 const mockShellEnv = jest.fn();
 jest.mock('shell-env', () => mockShellEnv);
 
 describe('exec', () => {
-  const oldPlatform = process.platform;
-
   // Allow us to reset the module between each run
   let execModule = require('../../src/utils/exec');
 
@@ -16,9 +16,7 @@ describe('exec', () => {
   });
 
   afterEach(() => {
-    Object.defineProperty(process, 'platform', {
-      value: oldPlatform,
-    });
+    resetPlatform();
   });
 
   describe('exec()', () => {
@@ -76,29 +74,23 @@ describe('exec', () => {
 
   describe('maybeFixPath()', () => {
     it('does not do anything on Windows', async () => {
-      Object.defineProperty(process, 'platform', {
-        value: 'win32',
-      });
+      overridePlatform('win32');
 
       await execModule.maybeFixPath();
 
       expect(mockShellEnv).toHaveBeenCalledTimes(0);
     });
 
     it('calls shell-env on macOS', async () => {
-      Object.defineProperty(process, 'platform', {
-        value: 'darwin',
-      });
+      overridePlatform('darwin');
 
       await execModule.maybeFixPath();
 
       expect(mockShellEnv).toHaveBeenCalledTimes(1);
     });
 
     it('calls shell-env on Linux', async () => {
-      Object.defineProperty(process, 'platform', {
-        value: 'linux',
-      });
+      overridePlatform('linux');
 
       await execModule.maybeFixPath();