build(deps): upgrade webpack-dev-server to v5.2.4 on next#4308
Merged
Conversation
Bumps webpack-dev-server in @electron-forge/plugin-webpack from ^4.0.0 to ^5.2.4 to resolve the moderate advisory GHSA-9jgg-88mc-972h. Mirrors the fix merged to main in #4274; re-applied manually because that commit does not cherry-pick cleanly onto next. The eslint-disable import/default suppression from #4274 is intentionally omitted here: next has migrated linting from ESLint to oxlint, and the import/default rule is not enabled in .oxlintrc.json, so oxlint reports no error on the default `import WebpackDevServer from 'webpack-dev-server'`. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0181gUdj5iDhqVyJjakQbuei
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
MarshallOfSound
approved these changes
Jul 1, 2026
MarshallOfSound
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Samuel Attard · Slack thread
Summarize your changes:
Bumps
webpack-dev-serverin@electron-forge/plugin-webpackfrom^4.0.0to^5.2.4on the release-bearingnextbranch.Before:
nextpinswebpack-dev-server ^4.0.0, which is affected by the moderate advisory GHSA-9jgg-88mc-972h (source code can be stolen via a malicious site in a non-Chromium browser).After: bumped to
^5.2.4(resolves to5.2.5in the lockfile), resolving the advisory.How: mirrors the fix already merged to
mainin #4274; re-applied manually because that commit does not cherry-pick cleanly ontonext(branches diverged since Nov 2025).One deliberate difference from #4274: the
// eslint-disable-next-line import/defaultsuppression added onmainis not needed here.nexthas migrated its JS/TS linting from ESLint to oxlint (.oxlintrc.json), and theimport/defaultrule is not enabled in that config.oxlintreports 0 errors on the unchanged default importimport WebpackDevServer from 'webpack-dev-server';in bothConfig.tsandWebpackPlugin.ts, and the package type-checks/builds cleanly under wds v5.Reference: fixes part of #4084 on the release-bearing
nextbranch (mainwas already fixed by #4274).Generated by Claude Code