fix(core): disable concurrency for package subtasks#4309
Merged
Conversation
MarshallOfSound
approved these changes
Jul 1, 2026
erickzhao
approved these changes
Jul 2, 2026
erickzhao
changed the title
erickzhao
changed the title
The inner package subtask list (copy-files, prepare-native-dependencies, finalize-package) was unintentionally inheriting "concurrent": true from the list of targets a couple of levels up. As a result all three subtasks appear to start simultaneously in CI logs even though the underlying work in @electron/packager runs sequentially. Set concurrent: false on that inner list so the subtasks render sequentially. Co-authored-by: Ryan Fitzgerald <rwfitzge@gmail.com>
claude
Bot
force-pushed
the
port-package-concurrency
branch
from
d972900 to
c1faaf9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Samuel Attard · Slack thread
Summarize your changes:
Backport of #4276 to the
nextbranch (Forge 8 / ESM).Before: The inner package subtask list (
copy-files,prepare-native-dependencies,finalize-package) inheritedconcurrent: truefrom the target list a couple of levels up, so all three subtasks render as if they start simultaneously in the terminal / CI log — making it look like, for example,prepare-native-dependenciesbegan beforecopy-filesfinished, which is not what actually happens.After: The three subtasks render sequentially, matching the real execution order (the underlying work in
@electron/packagerruns sequentially).How: Set
concurrent: falseon the innertask.newListr([...])options object inpackages/api/core/src/api/package.ts— the same list #4276 targeted onmain. Parent-list behavior is unchanged.Generated by Claude Code