ci: pin macOS test runners to macos-15#1929
Merged
Merged
Conversation
GitHub is rolling out a new macos-26-arm64 image behind the macos-latest label. On that image, `codesign --verify` rejects app bundles signed by the test suite's self-signed certificate with "code has no resources but signature indicates they must be present", so the `packager > macOS > codesign > can sign the app` test fails deterministically. The same commits pass on macos-15-arm64. Pin the test matrix to macos-15 until @electron/osx-sign is compatible with macOS 26's codesign behavior.
MarshallOfSound
approved these changes
Jul 3, 2026
erickzhao
approved these changes
Jul 3, 2026
|
🎉 This PR is included in version 20.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Samuel Attard · Slack thread
Summarize your changes:
Before: macOS CI randomly fails
packager > macOS > codesign > can sign the appwithcode has no resources but signature indicates they must be presentwhenever the job happens to land on GitHub's in-rolloutmacos-26-arm64image behind themacos-latestlabel.After: test jobs run on
macos-15, where signing verifies and the test passes.How: GitHub is mid-rollout of
macos-latestto a newmacos-26-arm64(Tahoe) image, so image assignment is effectively roulette during the rollout and the failure presented as flake. It is actually deterministic per image — the image-to-result correlation is 5/5 across the observed runs, including the same commit failing and passing depending only on which image it drew:can sign the appmainrun 28133623467 (2026-06-24)macos-26-arm64macos-26-arm64macos-15-arm64macos-15-arm64Pinning the test matrix to
macos-15restores deterministic CI. This is a stopgap: the real follow-up is@electron/osx-signcompatibility with macOS 26'scodesignbehavior, to be tracked separately.🤖 Generated with Claude Code
https://claude.ai/code/session_01U2ozTKKr7cZU29WpC61F3j