test: giving steroids to the test suite 💪 (#122)

* purely test suite on steroids

* verify stuff

* more fun verifies

* ok ok ok I'm done

* extend timeout and consolidate to constant for easier usage across tests

* PR feedback :)
Remove warnings by adding transform regex to `ts-jest` and `testMatch`.

* cleanup

* cleanup

* PR feedback & converting `export function` to `export const` in `util.ts`

Author: mmaietta

jest.config.js

@@ -3,13 +3,14 @@ module.exports = {
   preset: 'ts-jest',
   testEnvironment: 'node',
   transform: {
-    '.': [
+    '^.+\\.ts?$': [
       'ts-jest',
       {
-        tsconfig: 'tsconfig.jest.json'
-      }
-    ]
+        tsconfig: 'tsconfig.jest.json',
+      },
+    ],
   },
+  testMatch: ['<rootDir>/test/**/*.spec.ts'],
   globalSetup: './jest.setup.ts',
   testTimeout: 10000,
-};
+};

jest.setup.ts

@@ -1,28 +1,6 @@
-import { downloadArtifact } from '@electron/get';
-import * as zip from 'cross-zip';
 import * as fs from 'fs-extra';
 import * as path from 'path';
-
-const asarsDir = path.resolve(__dirname, 'test', 'fixtures', 'asars');
-const appsDir = path.resolve(__dirname, 'test', 'fixtures', 'apps');
-
-const templateApp = async (
-  name: string,
-  arch: string,
-  modify: (appPath: string) => Promise<void>,
-) => {
-  const electronZip = await downloadArtifact({
-    artifactName: 'electron',
-    version: '27.0.0',
-    platform: 'darwin',
-    arch,
-  });
-  const appPath = path.resolve(appsDir, name);
-  zip.unzipSync(electronZip, appsDir);
-  await fs.rename(path.resolve(appsDir, 'Electron.app'), appPath);
-  await fs.remove(path.resolve(appPath, 'Contents', 'Resources', 'default_app.asar'));
-  await modify(appPath);
-};
+import { appsDir, asarsDir, templateApp } from './test/util';
 
 export default async () => {
   await fs.remove(appsDir);

src/asar-utils.ts

@@ -84,8 +84,10 @@ export const mergeASARs = async ({
 }: MergeASARsOptions): Promise<void> => {
   d(`merging ${x64AsarPath} and ${arm64AsarPath}`);
 
-  const x64Files = new Set(asar.listPackage(x64AsarPath).map(toRelativePath));
-  const arm64Files = new Set(asar.listPackage(arm64AsarPath).map(toRelativePath));
+  const x64Files = new Set(asar.listPackage(x64AsarPath, { isPack: false }).map(toRelativePath));
+  const arm64Files = new Set(
+    asar.listPackage(arm64AsarPath, { isPack: false }).map(toRelativePath),
+  );
 
   //
   // Build set of unpacked directories and files