fix: don't use relative image links in Wayland blog post#1056
Merged
Conversation
Deploying electron-website with
|
| Latest commit: |
bd7dc40
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d1222d14.electron-website.pages.dev |
| Branch Preview URL: | https://fix-no-relative-image-links.electron-website.pages.dev |
erickzhao
reviewed
Mar 20, 2026
erickzhao
left a comment
Member
There was a problem hiding this comment.
oh no
i had specifically changed those around to fix the markdown linter:
Broken link on line 30: File does not exist at path: /home/runner/work/website/website/assets/img/blog/tech-talk-wayland/xwayland.png
Member
Author
|
@erickzhao, yea, I don't think the check blog links check plays nice with the absolute links. 😅 Probably needs a rethink, but I think we can safely ignore that for now, the preview looks good. |
erickzhao
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
These relative links break the i18n build since the pathing is different:
Checklist