Skip to content

fix: don't use relative image links in Wayland blog post#1056

Merged
erickzhao merged 1 commit into
mainfrom
fix/no-relative-image-links-wayland
Mar 20, 2026
Merged

fix: don't use relative image links in Wayland blog post#1056
erickzhao merged 1 commit into
mainfrom
fix/no-relative-image-links-wayland

Conversation

@dsanders11

Copy link
Copy Markdown
Member

Description of Change

These relative links break the i18n build since the pathing is different:

Cause: Markdown image with URL ../static/assets/img/blog/tech-talk-wayland/xwayland.png in source file "i18n/de/docusaurus-plugin-content-blog/tech-talk-wayland.md" (30:2) couldn't be resolved to an existing local image file.

Checklist

  • This PR was not created with AI. (PRs created mainly with AI will be closed. They waste our team's time. We ban repeat offenders.)

@dsanders11 dsanders11 requested a review from a team as a code owner March 20, 2026 22:03
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying electron-website with  Cloudflare Pages  Cloudflare Pages

Latest commit: bd7dc40
Status: ✅  Deploy successful!
Preview URL: https://d1222d14.electron-website.pages.dev
Branch Preview URL: https://fix-no-relative-image-links.electron-website.pages.dev

View logs

@dsanders11 dsanders11 marked this pull request as draft March 20, 2026 22:04

@erickzhao erickzhao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh no

i had specifically changed those around to fix the markdown linter:

	Broken link on line 30: File does not exist at path: /home/runner/work/website/website/assets/img/blog/tech-talk-wayland/xwayland.png

@dsanders11

Copy link
Copy Markdown
Member Author

@erickzhao, yea, I don't think the check blog links check plays nice with the absolute links. 😅 Probably needs a rethink, but I think we can safely ignore that for now, the preview looks good.

@dsanders11 dsanders11 marked this pull request as ready for review March 20, 2026 22:13
@erickzhao erickzhao merged commit dbec29e into main Mar 20, 2026
6 of 7 checks passed
@erickzhao erickzhao deleted the fix/no-relative-image-links-wayland branch March 20, 2026 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants