Skip to content

fix getChild before rageshake setup#4088

Merged
toger5 merged 6 commits into
livekitfrom
toger5/logger-getChild-fix
Jul 8, 2026
Merged

fix getChild before rageshake setup#4088
toger5 merged 6 commits into
livekitfrom
toger5/logger-getChild-fix

Conversation

@toger5

@toger5 toger5 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Content

Fix missing logs in rageshakes. (yes there was another issue, the first one was using the same rageshake db as EW)
The issue:

  • rageshake loggers are setup on the root logger via the rageshakes file init() method.
  • files that used const logger = rootLogger.getChild("[childscopename]"); often executed before the init call.
  • so the logger would be created before the parent logger got configured to use the rageshake log extension.
  • we ended up missing a large amount of logs

Motivation and context

We need those logs. This Issue revealed the missing logs:
#4087
(we first got locally recorded logs from android via logcat and then a rageshake.)

Tests

uploaded logs before this change:
https://github.com/element-hq/element-call-rageshakes/issues/16750

  • [CallViewModel] is missing [CallViewModel localTransport$] Creating item with keys compatibility ... does exisint but that is from the item with keys logging... not the getChild one

after changing some (first commit):
https://github.com/element-hq/element-call-rageshakes/issues/16754

  • [CallViewModel][1783444309670] exists!!
  • but [InCallView] is missing

after updating all logs:
https://github.com/element-hq/element-call-rageshakes/issues/16755

  • we should have all logs now. including [InCallView] (only gets logged on fatal errors so not visible in rageshake)

Checklist

  • A linked, pre-approved issue exists for this feature or UI change.
  • I have read CONTRIBUTING.md in full.
  • Pull request includes screenshots or videos for any UI changes.
  • Tests written for new code (and existing touched code where feasible).
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@toger5 toger5 added the PR-Developer-Experience Release note category. A PR that does not change EC but improves working with the repository. label Jul 7, 2026

@Johennes Johennes left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, nice find! And amazing that this even adds a lint rule to prevent future regressions. ❤️

@toger5 toger5 merged commit f2c42c3 into livekit Jul 8, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Developer-Experience Release note category. A PR that does not change EC but improves working with the repository.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants