Add enableClientWellKnownLookups#4103
Draft
langleyd wants to merge 2 commits into
Draft
Conversation
Gate client well-known lookups on enableClientWellKnownLookups New URL param (default on), threaded from the embedder. When off, always avoid client .well-known: skip the post-login poll (widget + SPA) and the legacy MatrixRTC foci fallback. When on/unset, respect the transports endpoint response: only fall back to .well-known on a 404 M_UNRECOGNIZED.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds gating (default on) so a deployment can stop Element Call making client
.well-knownrequests to the homeserverserver_name. Set via theenableClientWellKnownLookupsURL param in widget mode (by the embedder) andenable_client_well_known_lookupsinconfig.jsonin SPA mode; resolution isURL param → config → default on.
.well-known— skips the post-login poll(
widget.tswidget mode,utils/matrix.tsSPA mode) and the legacy MatrixRTCfoci fallback.
.well-knownfortransports on a
404 M_UNRECOGNIZED; any other response is authoritative.Element web embedded:
Complementary to element-hq/element-web#34084.
If remove
element_call.disablein EW config but keepenable_client_well_known_lookupsEC will continue to respect it (as long as it passes in the URL Param).matrix-org/matrix-js-sdk#5245 can then be added on top and will allow EC to function in EW alongside
enable_client_well_known_lookups.