[Story] Browse, manager and invite users to a space

[Velin92]

Description

Story

As a user that has joined the space
I want to browse the members list of the space
so that I can view their profiles, invite new members or manage them if I have the right permissions.

Acceptance criteria

The user needs to access the view through the more button of the space, when is in the joined state.
Then these may vary according to the permissions of the user:

• The user can browse and see all the members of the space and their profile
• The user can invite other user to the space
• They can view their profile
• Remove/Ban them from the space
• See the list of banned members

Designs

iOS
Android

[Velin92]

Deleted the "change their role" from the acceptance criteria, since it's an additional feature that will also impact rooms, that doesn't need to be included with just viewing and managing the members list.

[manuroe]

I should report here the issues I found when testing it 2 weeks ago:

iOS

• Not reactive on power level change. It is on ban status. Fixed by Fix: update members on power level changes in members list element-x-ios#4707.

Android

• Members still listed as banned after unbanning them (tested on an invitee). Trying to unban them again leads to an error
• Should display the profile bottom sheet when tapping of an unbanned user instead of displaying a confirmation dialog to unban them

[manuroe]

One issue left on Android discussed with @ganfra :

• Starting from the "Banned" tab, if you open and leave the profile screen, you come back to the "Members" tab, not the "Banned" tab as expected. The user loses the navigation context.

[mxandreas]

I did a little bit of exploratory testing on inviting/managing space members. Here are the observations:

1. The push notification tells you that you have been invited to a room. I think it would be good if we could be more specific and say explicitly if you are invited to a room or to a space.

2. iOS does not show a display name for a banned member and the username is in bold. Android shows it in the "usual" way.

3. Android - searching banned users does not seem to work.

[pixlwave]

Seems like 2. is a change from the original designs for a Room (iOS / Android) and the new ones for Space (iOS / Android).

FWIW, when we implemented the designs for a room it was done to reduce the impact of potentially offensive profiles.

[mxandreas]

FWIW, when we implemented the designs for a room it was done to reduce the impact of potentially offensive profiles.

This actually makes sense but it looks like Android never implemented this "redaction". We should do the same for both spaces and rooms, as well as on both platforms. I prefer the "redacted" version with just MXID - because you usually only ban when there's a good reason and then it is better to optimize for potentially offensive cases. @americanrefugee your thoughts?

[americanrefugee]

Updated designs...

Member list

• iOS
• Android

Member profile preview

• iOS
• Android

Banned list

• iOS
• Android

Banned profile preview

• iOS
• Android

[mxandreas]

@americanrefugee Did anything actually change for non-banned member list/profile view?
@ganfra Could you please confirm if searching for banned members works for you or not?
@americanrefugee What shall we do with the push notification copy? Should we generalize it, too?

[americanrefugee]

@americanrefugee Did anything actually change for non-banned member list/profile view?

No. I only changed the banned user list / profile.

@americanrefugee What shall we do with the push notification copy? Should we generalize it, too?

What do you mean by "push" notification? This?