Skip to content

Document recovery and backup_disabled account data#3064

Merged
uhoreg merged 3 commits into
developfrom
uhoreg/document_recovery_and_backup_disabled
Jan 21, 2026
Merged

Document recovery and backup_disabled account data#3064
uhoreg merged 3 commits into
developfrom
uhoreg/document_recovery_and_backup_disabled

Conversation

@uhoreg
Copy link
Copy Markdown
Member

@uhoreg uhoreg commented Dec 11, 2025

No description provided.

@uhoreg uhoreg marked this pull request as ready for review December 15, 2025 15:44
@uhoreg uhoreg requested a review from richvdh December 15, 2025 15:45
Copy link
Copy Markdown
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As already discussed elsewhere:

  • I think it might be a bit too verbose.

    I realise (somewhat belatedly) that that's what the existing files in element-meta/spec are doing, but I don't really think it's appropriate to follow the MSC format here. If we wanted to make a proposal to change the spec, complete with problem statement, proposal, and security considerations, then why wouldn't we make it an actual MSC.

    The whole point here is that Element has already decided to introduce these new account data events, and now we just need to record their existence and write down their semantics.

  • It kinda feels like we need a top-level doc saying:

    The Element apps use these non-standard events:
    
    # Account data events
    
    - io.element.recovery
    - io.element.xyz
    

    ... with a link to the doc for each event

  • also also.... I'm not really sure we need a separate doc for m.org.matrix.custom.backup_disabled, given it's documented as part of MSC4287?

    the main thing to have something to link to from the code, and we can do that with the MSC?

@uhoreg uhoreg requested a review from richvdh January 19, 2026 23:59
@uhoreg
Copy link
Copy Markdown
Member Author

uhoreg commented Jan 20, 2026

I've simplified the docs, and added a top-level doc summarizing the event types. I kept the documentation for m.org.matrix.custom.backup_disabled since it's already written.

Copy link
Copy Markdown
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYVM

@uhoreg uhoreg merged commit 3facdf2 into develop Jan 21, 2026
1 check passed
@uhoreg uhoreg deleted the uhoreg/document_recovery_and_backup_disabled branch January 21, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants