Skip to content

Do not show membership/profile events in public rooms#33192

Draft
bxdxnn wants to merge 4 commits into
element-hq:developfrom
bxdxnn:feature/no-member-events-flood
Draft

Do not show membership/profile events in public rooms#33192
bxdxnn wants to merge 4 commits into
element-hq:developfrom
bxdxnn:feature/no-member-events-flood

Conversation

@bxdxnn

@bxdxnn bxdxnn commented Apr 17, 2026 •
edited
Loading

Copy link
Copy Markdown

See element-hq/element-x-android#6360

Checklist

@github-actions github-actions Bot added the Z-Community-PR Issue is solved by a community member's PR label Apr 17, 2026
@bxdxnn bxdxnn marked this pull request as ready for review April 17, 2026 20:01
@bxdxnn bxdxnn requested a review from a team as a code owner April 17, 2026 20:01
@bxdxnn bxdxnn requested review from dbkr and t3chguy April 17, 2026 20:01
@t3chguy t3chguy requested a review from a team April 17, 2026 20:42
@t3chguy

t3chguy commented Apr 17, 2026

Copy link
Copy Markdown
Member

Please write tests before seeking review

@bxdxnn bxdxnn force-pushed the feature/no-member-events-flood branch from 92c71ca to 590238c Compare April 18, 2026 15:13
@t3chguy

t3chguy commented Apr 20, 2026

Copy link
Copy Markdown
Member

@bxdxnn bxdxnn force-pushed the feature/no-member-events-flood branch from 92c71ca to 590238c
2 days ago

Please read the contributing guide again.

https://github.com/element-hq/element-web/blob/develop/CONTRIBUTING.md#:~:text=Please%20do%20not%20use%20force%20push%20in%20your%20PRs.%20Doing%20so%20means%20we%20can%27t%20see%20what%20has%20changed.%20We%20use%20squash%20merge%20to%20get%20a%20%22clean%22%20git%20history.

t3chguy
t3chguy reviewed Apr 20, 2026
View reviewed changes

@t3chguy t3chguy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dismissing code review until Product reviews it

@t3chguy t3chguy removed the request for review from dbkr April 20, 2026 07:39
@bxdxnn

bxdxnn commented Apr 20, 2026

Copy link
Copy Markdown
Author

@bxdxnn bxdxnn force-pushed the feature/no-member-events-flood branch from 92c71ca to 590238c
2 days ago

Please read the contributing guide again.

https://github.com/element-hq/element-web/blob/develop/CONTRIBUTING.md#:~:text=Please%20do%20not%20use%20force%20push%20in%20your%20PRs.%20Doing%20so%20means%20we%20can%27t%20see%20what%20has%20changed.%20We%20use%20squash%20merge%20to%20get%20a%20%22clean%22%20git%20history.

Sorry, I was thinking you didn't review it.

@mxandreas

mxandreas commented Apr 20, 2026

Copy link
Copy Markdown
Member

As I already commented on the Android PR, this topic need comprehensive handling not local patches for specific use cases or pain: element-hq/element-x-android#6360 (comment)

From product/design perspective we can't accept this as is.

@bxdxnn bxdxnn marked this pull request as draft April 20, 2026 10:50
@bxdxnn bxdxnn marked this pull request as ready for review June 4, 2026 12:27
@bxdxnn

bxdxnn commented Jun 4, 2026

Copy link
Copy Markdown
Author

@t3chguy seems to be OK, I've reimplemented it based on the existing option. See element-hq/element-x-android#6360 (comment) and element-hq/element-x-android#6360 (comment)

@t3chguy

t3chguy commented Jun 4, 2026

Copy link
Copy Markdown
Member

Still needs a product person to tick it before it can progress

@bxdxnn bxdxnn marked this pull request as draft June 4, 2026 12:31
@bxdxnn bxdxnn changed the title Do not show membership/profile/topic events in public rooms Do not show membership/profile events in public rooms Jun 4, 2026
@bxdxnn bxdxnn force-pushed the feature/no-member-events-flood branch from c87e29e to 01cd27e Compare June 4, 2026 15:59
@bxdxnn bxdxnn marked this pull request as ready for review June 4, 2026 15:59
@bxdxnn bxdxnn requested a review from t3chguy June 4, 2026 16:03
@bxdxnn

bxdxnn commented Jun 4, 2026

Copy link
Copy Markdown
Author

Had to force-push because I forgot to revert the previous implementation before doing this one, it was easier to just start from scratch.

@bxdxnn bxdxnn marked this pull request as draft June 4, 2026 16:08
@bxdxnn bxdxnn marked this pull request as ready for review June 4, 2026 16:20
@t3chguy

t3chguy commented Jun 5, 2026

Copy link
Copy Markdown
Member

Tests written for new code (and old code if feasible).

Not seeing any tests you have written

Linter and other CI checks pass.

CI is unhappy with you. You have failing linters & tests.

t3chguy
t3chguy reviewed Jun 5, 2026
View reviewed changes
Comment thread apps/web/test/unit-tests/shouldHideEvent-test.ts Outdated
@bxdxnn bxdxnn marked this pull request as draft June 8, 2026 09:20
@bxdxnn bxdxnn marked this pull request as ready for review June 15, 2026 09:11
@t3chguy t3chguy mentioned this pull request Jun 17, 2026
Closed
@Half-Shot Half-Shot requested a review from t3chguy June 18, 2026 09:09
t3chguy
t3chguy requested changes Jun 18, 2026
View reviewed changes

@t3chguy t3chguy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you still have failing tests

@bxdxnn bxdxnn marked this pull request as draft June 18, 2026 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t3chguy t3chguy t3chguy requested changes
@mxandreas mxandreas mxandreas approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

T-Enhancement Z-Community-PR Issue is solved by a community member's PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bxdxnn @t3chguy @mxandreas @RiotRobot