Skip to content

Harden settings types#33311

Merged
t3chguy merged 4 commits into
developfrom
t3chguy/harden-settings
Apr 29, 2026
Merged

Harden settings types#33311
t3chguy merged 4 commits into
developfrom
t3chguy/harden-settings

Conversation

@t3chguy
Copy link
Copy Markdown
Member

@t3chguy t3chguy commented Apr 28, 2026

No description provided.

@t3chguy t3chguy added the T-Task Tasks for the team like planning label Apr 28, 2026
@t3chguy t3chguy self-assigned this Apr 28, 2026
@t3chguy t3chguy added the Z-Skip-Coverage Skip SonarQube coverage for this PR label Apr 28, 2026
@t3chguy t3chguy marked this pull request as ready for review April 28, 2026 12:06
@t3chguy t3chguy requested a review from a team as a code owner April 28, 2026 12:06
@t3chguy t3chguy requested review from MidhunSureshR and dbkr April 28, 2026 12:06
Copy link
Copy Markdown
Member

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than

// even if you haven't used your typically favourite emoji for a little while.
const STORAGE_LIMIT = 100;

// TODO remove this after some time
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another of my PRs does actually remove it

Comment thread apps/web/src/emojipicker/recent.ts Outdated
Co-authored-by: Will Hunt <2072976+Half-Shot@users.noreply.github.com>
@t3chguy t3chguy added this pull request to the merge queue Apr 29, 2026
Merged via the queue into develop with commit 5ff3025 Apr 29, 2026
63 of 67 checks passed
@t3chguy t3chguy deleted the t3chguy/harden-settings branch April 29, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-Task Tasks for the team like planning Z-Skip-Coverage Skip SonarQube coverage for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants