Default the Ctrl/Cmd+F search shortcut to in-room search on desktop#34005
Open
hayaksi1 wants to merge 1 commit into
Open
Default the Ctrl/Cmd+F search shortcut to in-room search on desktop#34005hayaksi1 wants to merge 1 commit into
hayaksi1 wants to merge 1 commit into
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
ctrlFForSearchsetting (Ctrl/Cmd+F opens in-room message search instead of thebrowser's find-on-page) shipped off by default for everyone and with no description,
so the shortcut most users expect to search the conversation did nothing useful out of the
box. On the desktop app there is no browser "find on page" for it to clash with, and Seshat
makes encrypted-room search work, so defaulting it off there is a missed default. On web the
opposite is true — overriding the browser's native Ctrl+F is surprising. The setting therefore
wants different defaults on the two platforms (#24359), and a description so users understand
what it does (#22888).
Fix
ctrlFForSearchto on for the desktop app (!!IS_ELECTRON) and keep it off onweb, so the desktop app searches the room by default while web preserves the browser's
native find bar.
descriptionto the setting explaining what the shortcut does and that encrypted-roomsearch needs the desktop app with message search enabled.
No new UI surface — this is a default + copy change on the existing setting, confined to
Settings.tsxand the i18n string. The settings-tab snapshot is regenerated to include thenew description.
Tests
KeyBindingsDefaults-test.ts: the Ctrl/Cmd+F room-search keybinding is registered whenctrlFForSearchis enabled and omitted when it is disabled.PreferencesUserSettingsTabsnapshot updated for the added description.Fixes #22888
Relates to #24359
Checklist
public/exportedsymbols have accurate TSDoc documentation.