Step through search matches across rooms in an all-rooms search#34009
Open
hayaksi1 wants to merge 2 commits into
Open
Step through search matches across rooms in an all-rooms search#34009hayaksi1 wants to merge 2 commits into
hayaksi1 wants to merge 2 commits into
Conversation
This was referenced Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In-room match stepping (#34008) steps through matches in the current room only — in an all-rooms
search the match stepper is disabled, even though the results span multiple rooms. There is no way
to step from a match in one room to a match in another.
Fix
Extend the stepping cursor (
SearchSessionStore) to span rooms: in an all-rooms search the matchlist is no longer filtered to the current room, so the up/down arrows step across every room's
matches (including matches in predecessor/upgraded rooms), switching the viewed room as needed. The
session cursor already lives outside any single
RoomView, so the focused match survives the roomswitch.
Tests
RoomView-test: stepping into a predecessor-room match, and enabling the stepper for an all-roomssearch so it steps across rooms.
Relates to #21640
Relates to #32341
Checklist
public/exportedsymbols have accurate TSDoc documentation.