Skip to content

Step through search matches across rooms in an all-rooms search#34009

Open
hayaksi1 wants to merge 2 commits into
element-hq:developfrom
hayaksi1:pr/search-all-rooms
Open

Step through search matches across rooms in an all-rooms search#34009
hayaksi1 wants to merge 2 commits into
element-hq:developfrom
hayaksi1:pr/search-all-rooms

Conversation

@hayaksi1

Copy link
Copy Markdown

Stacked on #34008 (in-room match stepping) and design-gated under #21640. Please review
#34008 first — the diff here includes it and will reduce once it merges. Happy to align the UX
with the match-presentation design discussion before this merges.

Problem

In-room match stepping (#34008) steps through matches in the current room only — in an all-rooms
search the match stepper is disabled, even though the results span multiple rooms. There is no way
to step from a match in one room to a match in another.

Fix

Extend the stepping cursor (SearchSessionStore) to span rooms: in an all-rooms search the match
list is no longer filtered to the current room, so the up/down arrows step across every room's
matches (including matches in predecessor/upgraded rooms), switching the viewed room as needed. The
session cursor already lives outside any single RoomView, so the focused match survives the room
switch.

Tests

RoomView-test: stepping into a predecessor-room match, and enabling the stepper for an all-rooms
search so it steps across rooms.

Relates to #21640
Relates to #32341

Checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Z-Community-PR Issue is solved by a community member's PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant