Remove legacy room list#34040
Merged
Merged
Conversation
florianduros
force-pushed
the
florianduros/remove-old-room-list
branch
from
0df4846 to
1d15ee0
Compare
Closed
florianduros
force-pushed
the
florianduros/remove-old-room-list
branch
from
1d15ee0 to
9ead9ea
Compare
florianduros
force-pushed
the
florianduros/remove-old-room-list
branch
from
9ead9ea to
1fc0277
Compare
florianduros
force-pushed
the
florianduros/remove-old-room-list
branch
from
1fc0277 to
7eb3d2a
Compare
SpaceStore.setActiveRoomInSpace iterated the legacy RoomListStore's `orderedLists` in `TAG_ORDER`; switch it to the space-aware RoomListStoreV3.getSortedRoomsInActiveSpace() accessor. This drops the last non-UI dependency on the legacy store and on `TAG_ORDER` (exported from LegacyRoomList, deleted next).
Delete the old sublist-based room list and its components now that the new RoomListPanel is the default. Removed: LegacyRoomList, LegacyRoomListHeader, RoomSublist, ExtraTile, RoomTile (+ Subtitle/ CallSummary), RoomBreadcrumbs and RoomSearch, plus their styles and tests. LeftPanel collapses to the RoomListPanel-only path. The shared `contextMenuBelow` helper is relocated into RoomResultContextMenus (its only remaining consumer).
The legacy sublist-based room list UI is gone, so the old `stores/room-list` store (Algorithm, sorters, filters, layout store, space watcher) has no remaining consumers. Delete the directory and its tests. MatrixChat.forgetRoom no longer calls the legacy `manualRoomUpdate`; the new room list store removes the room on the `AfterForgetRoom` dispatch that still fires. Drop the `mxRoomListStore`/`mxRoomListLayoutStore` globals and the now-dead test imports.
The new room list is now the only room list, so remove the feature_new_room_list labs flag and make its enabled behaviour unconditional everywhere it was gated: - LoggedInView: always use the resizable layout and NEW_ROOM_LIST_MIN_WIDTH; drop the collapsible/minimized legacy path. - SpaceStore: People and Favourites are dropped from metaSpaceOrder (per the long-standing TODO on the removed accessor). - MessagePreviewStore: stop appending thread replies to previews. - Settings, SidebarUserSettingsTab, PreferencesUserSettingsTab, QuickSettingsButton, SpacePanel, LandmarkNavigation: drop the flag reads and legacy branches. Update the tests that toggled the flag; the People/Favourites meta space tests covered behaviour that the flag (default on) already disabled.
LoggedInView still built the old `Resizer`/`CollapseDistributor` over an `lp-resizer` ResizeHandle and persisted `mx_lhs_size`. That handle is no longer rendered (the resizable layout is now driven by LeftResizablePanelView + ResizerViewModel, which persists its own state via RoomList.panelSize/RoomList.isPanelCollapsed), so the old resizer was inert dead code left over from the legacy room list. Remove createResizer/loadResizer/loadResizerPreferences, the _resizeContainer/resizeHandler refs, the ResizeHandle render, the mx_lhs_size handling and NEW_ROOM_LIST_MIN_WIDTH, plus the unit tests that exercised the mocked resizer.
`collapseLhs` is write-only since the left panel no longer collapses: it was last read by LoggedInView's `shouldUseMinimizedUI`, removed with the feature_new_room_list flag. Drop it from MatrixChat's IState (and its assignments), collapsing the hide/show_left_panel handlers to just the `notifyLeftHandleResized()` call they still need, and from LoggedInView's IProps and the test props.
Removing the unused SettingsStore import from MessagePreviewStore (when the feature_new_room_list flag was dropped) changed module load order and exposed a latent circular dependency: ReactionEventPreview imports MessagePreviewStore, which eagerly did `new ReactionEventPreview()` at module-eval — so importing ReactionEventPreview first (as its unit test does) hit "ReactionEventPreview is not a constructor". Construct the previewers lazily on first use (cached) instead of at module load, so nothing dereferences a mid-evaluation module. Fixes ReactionEventPreview-test.
florianduros
force-pushed
the
florianduros/remove-old-room-list
branch
from
7eb3d2a to
19d29bf
Compare
t3chguy
reviewed
Jul 1, 2026
t3chguy
reviewed
Jul 1, 2026
This reverts commit 4e6eedf.
t3chguy
reviewed
Jul 1, 2026
Contributor
|
We have not used the old room list for a long time in product, great to be removing old code. Thanks @florianduros |
daniellekirkwood
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #32736
closes #32691
The new room list (
RoomListPanel+room-list-v3store) has been the default for a while and we moved the section out of labs recently. This removes the legacy implementation entirely and deletes thefeature_new_room_listlabs flag.Changes
LegacyRoomList,LegacyRoomListHeader,RoomSublist,ExtraTile, theRoomTilesubtree,RoomBreadcrumbs, andRoomSearch(+ their styles/tests).LeftPanelnow renders onlyRoomListPanel.stores/room-liststore —Algorithm, sorters, filters, layout store, space watcher — and migrate its last consumer,SpaceStore.setActiveRoomInSpace, toRoomListStoreV3.feature_new_room_listlabs flag and inline the enabled behaviour everywhere it was gated (LoggedInView,MessagePreviewStore,SpaceStore,LandmarkNavigation, settings tabs,QuickSettingsButton,SpacePanel). People/Favourites are dropped frommetaSpaceOrder.Resizer, thecollapseLhsstate, and assorted unused files/exports (BackdropPanel,useHover,objectWithOnly,splitRoomsByMembership,DefaultTagID.Suggested, …).LeftResizablePanelView+ResizerViewModel.