Prevent user from starting LLS in thread#6767
Conversation
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6767 +/- ##
========================================
Coverage 81.15% 81.15%
========================================
Files 2647 2647
Lines 74042 74045 +3
Branches 9579 9581 +2
========================================
+ Hits 60091 60094 +3
Misses 10417 10417
Partials 3534 3534 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| } | ||
|
|
||
| private fun Timeline.Mode.canShareLiveLocation() = when (this) { | ||
| is Timeline.Mode.Thread -> false |
There was a problem hiding this comment.
Should this also exclude pinned events timeline? The current UI won't allow you to start a live location share in that screen, but it may be worth it to explicitly ensure that here.
There was a problem hiding this comment.
I thought about having all the case in the when statement, but I preferred to keep the code simple. Since there is no composer in Pinned event timeline, I guess it's fine. Maybe Timeline.Mode could have a read-only / writable concept.



Content
Prevent user from starting LLS in thread. We only allow sharing the current location in a thread.
Motivation and context
Part of #6764.
Other points of #6764 has to be handled by the SDK, this is done in matrix-org/matrix-rust-sdk#6563
Screenshots / GIFs
Tests
Tested devices
Checklist