Skip to content

Remove LiveLocationSharing feature flag#6811

Merged
ganfra merged 1 commit into
developfrom
feature/live_location_remove_feature_flag
May 19, 2026
Merged

Remove LiveLocationSharing feature flag#6811
ganfra merged 1 commit into
developfrom
feature/live_location_remove_feature_flag

Conversation

@ganfra
Copy link
Copy Markdown
Member

@ganfra ganfra commented May 18, 2026

Content

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • This PR was made with the help of AI:
    • Yes. In this case, please request a review by Copilot.
    • No.
  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly defines what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@ganfra ganfra added the PR-Feature For a new feature label May 18, 2026
@ganfra ganfra marked this pull request as ready for review May 18, 2026 18:26
@ganfra ganfra requested a review from a team as a code owner May 18, 2026 18:26
@ganfra ganfra requested review from jmartinesp and removed request for a team May 18, 2026 18:26
@github-actions
Copy link
Copy Markdown
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Vew7US

@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.27%. Comparing base (1111315) to head (828337b).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6811      +/-   ##
===========================================
- Coverage    81.27%   81.27%   -0.01%     
===========================================
  Files         2648     2648              
  Lines        74134    74124      -10     
  Branches      9616     9615       -1     
===========================================
- Hits         60251    60241      -10     
  Misses       10337    10337              
  Partials      3546     3546              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jmartinesp
Copy link
Copy Markdown
Member

Just checking, should we completely remove the feature flag or just enable it by default?

@manuroe
Copy link
Copy Markdown
Member

manuroe commented May 19, 2026

We are fine to remove it entirely.

Copy link
Copy Markdown
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ganfra ganfra merged commit 6cc2e59 into develop May 19, 2026
39 checks passed
@ganfra ganfra deleted the feature/live_location_remove_feature_flag branch May 19, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Feature For a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants