Skip to content

Disable cron jobs and private SSH key jobs in forks#6821

Draft
jmartinesp wants to merge 5 commits into
element-hq:developfrom
jmartinesp:ci/disable-cron-jobs-in-forks
Draft

Disable cron jobs and private SSH key jobs in forks#6821
jmartinesp wants to merge 5 commits into
element-hq:developfrom
jmartinesp:ci/disable-cron-jobs-in-forks

Conversation

@jmartinesp
Copy link
Copy Markdown
Member

Content

What the title says.

Motivation and context

I recently tested some changes related to forks in my fork of the repo and I started receiving periodic emails about the scheduled jobs/flows failing every day. On top of that, there were some other failures when the jobs required some credentials they didn't have (tokens, ssh keys, etc.).

With this, I stopped receiving emails for the cron jobs and I saw the same flows that previously failed because they lacked the required secrets succeed.

Checklist

  • This PR was made with the help of AI:
    • Yes. In this case, please request a review by Copilot.
    • No.
  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly defines what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@jmartinesp jmartinesp added the PR-Build For changes related to build, tools, CI/CD label May 20, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:

  • If your pull request adds a feature or modifies the UI, this should have an equivalent pull request in the Element X iOS repo unless it only affects an Android-only behaviour or is behind a disabled feature flag, since we need parity in both clients to consider a feature done. It will also need to be approved by our product and design teams before being merged, so it's usually a good idea to discuss the changes in a Github issue first and then start working on them once the approach has been validated.
  • Your branch should be based on origin/develop, at least when it was created.
  • The title of the PR will be used for release notes, so it needs to describe the change visible to the user.
  • The test pass locally running ./gradlew test.
  • The code quality check suite pass locally running ./gradlew runQualityChecks.
  • If you modified anything related to the UI, including previews, you'll have to run the Record screenshots GH action in your forked repo: that will generate compatible new screenshots. However, given Github Actions limitations, it will prevent the CI from running temporarily, until you upload a new commit after that one. To do so, just pull the latest changes and push an empty commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Build For changes related to build, tools, CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant