Skip to content

Hide edit pencil from accessibility#6826

Merged
bmarty merged 1 commit into
developfrom
feature/bma/a11y/avatarEdit
May 20, 2026
Merged

Hide edit pencil from accessibility#6826
bmarty merged 1 commit into
developfrom
feature/bma/a11y/avatarEdit

Conversation

@bmarty
Copy link
Copy Markdown
Member

@bmarty bmarty commented May 20, 2026

Content

Ensure that the unlabelled pencil icon is not focusable by the screen reader. This can be not focusable since the click action is the same than the avatar itself.

Motivation and context

Closes #6378

Screenshots / GIFs

Before After
Screenshot 2026-05-20 at 14 45 51 Screenshot 2026-05-20 at 14 49 32

After the pencil icon is not focusable.

Tests

  • Enable screenreader
  • start a room creation
  • add an avatar picture
  • focus on the avatar
  • see that the pencil icon is not focusable anymore.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • This PR was made with the help of AI:
    • Yes. In this case, please request a review by Copilot.
    • No.
  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly defines what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner May 20, 2026 12:54
@bmarty bmarty requested review from jmartinesp and removed request for a team May 20, 2026 12:54
@bmarty bmarty added the PR-Bugfix For bug fix label May 20, 2026
@github-actions
Copy link
Copy Markdown
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/rTVgAG

@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.26%. Comparing base (64d9336) to head (67c6689).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6826   +/-   ##
========================================
  Coverage    81.26%   81.26%           
========================================
  Files         2648     2648           
  Lines        74171    74173    +2     
  Branches      9622     9622           
========================================
+ Hits         60278    60280    +2     
  Misses       10341    10341           
  Partials      3552     3552           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@bmarty bmarty merged commit 0725c16 into develop May 20, 2026
38 of 39 checks passed
@bmarty bmarty deleted the feature/bma/a11y/avatarEdit branch May 20, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Bugfix For bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A11y: [New room] Pencil icon button for avatar menu is unlabelled (...

2 participants