Skip to content

[a11y] Improve accessibility of screen headers.#6827

Merged
bmarty merged 4 commits into
developfrom
feature/bma/a11y/roomNameHeading
May 21, 2026
Merged

[a11y] Improve accessibility of screen headers.#6827
bmarty merged 4 commits into
developfrom
feature/bma/a11y/roomNameHeading

Conversation

@bmarty
Copy link
Copy Markdown
Member

@bmarty bmarty commented May 20, 2026

Content

Improve accessibility of TopBar titles: Composable must have the heading() semantic property (as per the documentation).
Also group title and subtitle in some screens so they are read together.

Motivation and context

Closes #6387

Screenshots / GIFs

Tests

  • Enable TalkBack
  • Navigate to modified screens (space, media viewer, thread, thread list, room timeline) and observe that the top bars are declared as "header"

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • This PR was made with the help of AI:
    • Yes. In this case, please request a review by Copilot.
    • No.
  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly defines what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner May 20, 2026 13:57
@bmarty bmarty added the PR-Bugfix For bug fix label May 20, 2026
@bmarty bmarty requested review from ganfra and removed request for a team May 20, 2026 13:57
@github-actions
Copy link
Copy Markdown
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/xzALr2

@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.27%. Comparing base (64d9336) to head (df9a3fe).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6827   +/-   ##
========================================
  Coverage    81.26%   81.27%           
========================================
  Files         2648     2648           
  Lines        74171    74189   +18     
  Branches      9622     9622           
========================================
+ Hits         60278    60296   +18     
  Misses       10341    10341           
  Partials      3552     3552           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmarty bmarty merged commit c3a4d64 into develop May 21, 2026
42 checks passed
@bmarty bmarty deleted the feature/bma/a11y/roomNameHeading branch May 21, 2026 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Bugfix For bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A11y: [Send a message] Chat name functions as page heading but is impleme...

2 participants