Skip to content

Remove DI-generated code from Kover reports#6834

Open
jmartinesp wants to merge 2 commits into
developfrom
test/remove-di-generated-code-from-kover-reports
Open

Remove DI-generated code from Kover reports#6834
jmartinesp wants to merge 2 commits into
developfrom
test/remove-di-generated-code-from-kover-reports

Conversation

@jmartinesp
Copy link
Copy Markdown
Member

Content

What the title says.

Motivation and context

In #6832 I realised a DI-only change was causing generated code changes that modified the coverage.

This PR mostly reverts the coverage percentage lost by not measuring some common generated classed by Metro DI.

Tests

Coverage should go up. The regexes should be specific enough to only affect classes related to Metro DI, like:

image

Tested devices

  • Physical
  • Emulator
  • OS version(s): 15

Checklist

  • This PR was made with the help of AI:
    • Yes. In this case, please request a review by Copilot.
    • No.
  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly defines what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@jmartinesp jmartinesp added the PR-Build For changes related to build, tools, CI/CD label May 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/kQYZ26

@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.29%. Comparing base (5be14df) to head (bb99a7d).
⚠️ Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6834      +/-   ##
===========================================
+ Coverage    81.25%   81.29%   +0.03%     
===========================================
  Files         2652     2650       -2     
  Lines        74361    74328      -33     
  Branches      9639     9639              
===========================================
  Hits         60425    60425              
+ Misses       10378    10345      -33     
  Partials      3558     3558              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jmartinesp jmartinesp marked this pull request as ready for review May 22, 2026 05:58
@jmartinesp jmartinesp requested a review from a team as a code owner May 22, 2026 05:58
@jmartinesp jmartinesp requested review from ganfra and removed request for a team May 22, 2026 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Build For changes related to build, tools, CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant