Remove DI-generated code from Kover reports#6834
Open
jmartinesp wants to merge 2 commits into
Open
Conversation
Contributor
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6834 +/- ##
===========================================
+ Coverage 81.25% 81.29% +0.03%
===========================================
Files 2652 2650 -2
Lines 74361 74328 -33
Branches 9639 9639
===========================================
Hits 60425 60425
+ Misses 10378 10345 -33
Partials 3558 3558 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Content
What the title says.
Motivation and context
In #6832 I realised a DI-only change was causing generated code changes that modified the coverage.
This PR mostly reverts the coverage percentage lost by not measuring some common generated classed by Metro DI.
Tests
Coverage should go up. The regexes should be specific enough to only affect classes related to Metro DI, like:
Tested devices
Checklist