Fix public read receipts being sent by mistake#6838
Open
jmartinesp wants to merge 1 commit into
Open
Conversation
When returning to the chat screen from the room details one or a member's profile, `TimelineEvent.OnScrollFinished` will be called immediately, and this would read the default value for `isSendPublicReadReceiptsEnabled`, which is `true`. If you had public read receipts disabled, this is a mistake, and would send a public read receipt. Instead, what we want to do is wait until the updated value is emitted and use it to decide whether we want to send a public or private read receipt.
Contributor
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6838 +/- ##
===========================================
- Coverage 81.25% 81.25% -0.01%
===========================================
Files 2652 2652
Lines 74373 74366 -7
Branches 9641 9640 -1
===========================================
- Hits 60432 60425 -7
Misses 10381 10381
Partials 3560 3560 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
When returning to the chat screen from the room details one or a member's profile,
TimelineEvent.OnScrollFinishedwill be called immediately, and this would read the default value forisSendPublicReadReceiptsEnabled, which istrue.If you had public read receipts disabled, this is a mistake, and would send a public read receipt. Instead, what we want to do is wait until the updated value is emitted and use it to decide whether we want to send a public or private read receipt.
Motivation and context
Fixes #6836.
Tests
Previously, you'd see a public read receipt sent by mistake here.
Tested devices
Checklist